Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 1783063002: Revert of add Make variations to return SkImage by sk_sp (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
f(malita), bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ ) Reason for revert: Experimental revert to try to clear up ASAN failures Original issue's description: > add Make variations to return SkImage by sk_sp > > some internal call-sites update, but not. Will follow-up in future to complete that. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778393002 > > Committed: https://skia.googlesource.com/skia/+/bd73ffb83022f1f6b1997e2a91c049949e88a8a2 TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e683c56115a210b5993df9294260bb147b408bfa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -300 lines) Patch
M include/core/SkImage.h View 9 chunks +38 lines, -70 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/c/sk_surface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPictureShader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/image/SkImage.cpp View 8 chunks +36 lines, -108 lines 0 comments Download
M src/image/SkImagePriv.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Generator.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 7 chunks +39 lines, -41 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 7 chunks +41 lines, -40 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkBitmapSourceDeserializer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of add Make variations to return SkImage by sk_sp
4 years, 9 months ago (2016-03-11 00:18:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783063002/1
4 years, 9 months ago (2016-03-11 00:18:38 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 00:18:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e683c56115a210b5993df9294260bb147b408bfa

Powered by Google App Engine
This is Rietveld 408576698