Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6074)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1783053004: [MD settings] move Clear Browsing Data from _page.* to _dialog.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 0096961578b1dbb7e3d30be167e910009543b383..59240d7e26a74c432595ecfe468dc2e47244c32b 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -3,7 +3,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://md-settings/certificate_manager_page/certificate_manager_page.html">
-<link rel="import" href="chrome://md-settings/clear_browsing_data_page/clear_browsing_data_page.html">
+<link rel="import" href="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
dpapad 2016/03/11 23:51:04 How about eliminating the settings/clear_browsing_
dschuyler 2016/03/12 00:23:53 I think moving it is a good idea. Though I want
dpapad 2016/03/12 00:25:29 SGTM
<link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_animated_pages.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_subheader.html">
@@ -19,8 +19,8 @@
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="privacy">
<neon-animatable id="main">
- <settings-clear-browsing-data-page prefs="{{prefs}}">
- </settings-clear-browsing-data-page>
+ <settings-clear-browsing-data-dialog prefs="{{prefs}}">
+ </settings-clear-browsing-data-dialog>
<div class="settings-box block first">
<p class="privacy-explanation"
i18n-values=".innerHTML:improveBrowsingExperience">

Powered by Google App Engine
This is Rietveld 408576698