[MD settings] move Clear Browsing Data from _page.* to _dialog.*

[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739
Committed: https://crrev.com/51328f113889a8562fd9ea3fd5f92305337db6d2
Cr-Commit-Position: refs/heads/master@{#380826}

[dschuyler, 2016-03-11 23:39:28]

Description was changed from

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

BUG=532739
==========

to

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the 
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739
==========

[dschuyler, 2016-03-11 23:39:28]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-03-11 23:40:19]

note that the clear browsing data page .css
file is being removed in 
https://codereview.chromium.org/1783363006/

[dpapad, 2016-03-11 23:51:05]

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:6: <link
rel="import"
href="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
How about eliminating the settings/clear_browsing_data_dialog/ subfolder and
moving the 2 files (html, js) over to settings/privacy_page/? I don't think we
need a separate folder anymore, WDYT?

[dschuyler, 2016-03-12 00:23:53]

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:6: <link
rel="import"
href="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
On 2016/03/11 23:51:04, dpapad wrote:
> How about eliminating the settings/clear_browsing_data_dialog/ subfolder and
> moving the 2 files (html, js) over to settings/privacy_page/? I don't think we
> need a separate folder anymore, WDYT?

I think moving it is a good idea.  Though I 
want to see how things go with Clear Browsing
Data being used from chrome://history before
deciding where this should really be.

[dpapad, 2016-03-12 00:25:29]

lgtm

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1783053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:6: <link
rel="import"
href="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
On 2016/03/12 at 00:23:53, dschuyler wrote:
> On 2016/03/11 23:51:04, dpapad wrote:
> > How about eliminating the settings/clear_browsing_data_dialog/ subfolder and
> > moving the 2 files (html, js) over to settings/privacy_page/? I don't think
we
> > need a separate folder anymore, WDYT?
> 
> I think moving it is a good idea.  Though I 
> want to see how things go with Clear Browsing
> Data being used from chrome://history before
> deciding where this should really be.

SGTM

[dschuyler, 2016-03-12 00:38:48]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-12 00:38:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1783053004/#ps20001
(title: "merge with master")

[commit-bot: I haz the power, 2016-03-12 00:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783053004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783053004/20001

[commit-bot: I haz the power, 2016-03-12 01:37:36]

Description was changed from

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the 
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739
==========

to

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the 
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739
==========

[commit-bot: I haz the power, 2016-03-12 01:37:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-12 01:38:34]

Description was changed from

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the 
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739
==========

to

==========
[MD settings] move Clear Browsing Data from _page.* to _dialog.*

This CL is a file/directory rename along
with changes to the dom-module and the
open dialog function.  It's not a functional
change (i.e. code health).

BUG=532739

Committed: https://crrev.com/51328f113889a8562fd9ea3fd5f92305337db6d2
Cr-Commit-Position: refs/heads/master@{#380826}
==========

[commit-bot: I haz the power, 2016-03-12 01:38:36]

Patchset 2 (id:??) landed as
https://crrev.com/51328f113889a8562fd9ea3fd5f92305337db6d2
Cr-Commit-Position: refs/heads/master@{#380826}