Initial addition of blimp crash client code.

Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454
Committed: https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
Cr-Commit-Position: refs/heads/master@{#383161}

[marcinjb, 2016-03-23 23:50:26]

Description was changed from

==========
Initial addition of blimp crash client code.

BUG=
==========

to

==========
Initial addition of blimp crash client code.

BUG=597454
==========

[marcinjb, 2016-03-23 23:50:26]

marcinjb@chromium.org changed reviewers:
+ kmarshall@chromium.org, mark@chromium.org

[marcinjb, 2016-03-23 23:52:44]

+kmarshall for engine integration
+mark for components/crash

[Mark Mentovai, 2016-03-24 17:45:43]

LGTM limited to “OK to add this dependency.”

[Kevin M, 2016-03-24 20:14:32]

lgtm

A bit more detail about specific work items done in the CL description would be
appreciated.

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.h (right):

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.h:13: // Registers the crash keys
needed for the Blimp engine.
Document the return value

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_reporter_client.cc (right):

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:43: // Always collect
blimp engine crash reports.
nit: Blimp

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:51: process_type ==
::switches::kPpapiPluginProcess ||
Are we doing PPAPI?

[marcinjb, 2016-03-24 20:24:26]

Description was changed from

==========
Initial addition of blimp crash client code.

BUG=597454
==========

to

==========
Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454
==========

[marcinjb, 2016-03-24 20:27:03]

kmarshall: Just want to double check about how much we care about PPAPI.  If you
really don't care, I'll submit.

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.h (right):

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.h:13: // Registers the crash keys
needed for the Blimp engine.
On 2016/03/24 20:14:32, Kevin M wrote:
> Document the return value

Done.

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_reporter_client.cc (right):

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:43: // Always collect
blimp engine crash reports.
On 2016/03/24 20:14:32, Kevin M wrote:
> nit: Blimp

Done.

https://codereview.chromium.org/1783053002/diff/60001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:51: process_type ==
::switches::kPpapiPluginProcess ||
On 2016/03/24 20:14:32, Kevin M wrote:
> Are we doing PPAPI?

¯\_(ツ)_/¯

More seriously, there's no major downside to including this here. If we're not,
this is just one boolean value that won't trip.  If we decide further down the
road that we will, then no changes will be necessary.

If you feel strongly, I can easily remove this line.

[marcinjb, 2016-03-24 22:11:52]

The CQ bit was checked by marcinjb@chromium.org

[marcinjb, 2016-03-24 22:11:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/1783053002/#ps80001
(title: "Address kmarshall's comments")

[commit-bot: I haz the power, 2016-03-24 22:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783053002/80001

[commit-bot: I haz the power, 2016-03-24 22:20:39]

Description was changed from

==========
Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454
==========

to

==========
Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454
==========

[commit-bot: I haz the power, 2016-03-24 22:20:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-24 22:21:44]

Description was changed from

==========
Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454
==========

to

==========
Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG=597454

Committed: https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
Cr-Commit-Position: refs/heads/master@{#383161}
==========

[commit-bot: I haz the power, 2016-03-24 22:21:45]

Patchset 5 (id:??) landed as
https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
Cr-Commit-Position: refs/heads/master@{#383161}

[haibinlu, 2016-03-24 23:47:42]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1830393002/ by haibinlu@chromium.org.

The reason for reverting is: Engine crashes.
https://bugs.chromium.org/p/chromium/issues/detail?id=597838.