Issue 178303003: Merge 251963 "[Android] Use DIP coordinates for GestureFlingStar..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178303003: Merge 251963 "[Android] Use DIP coordinates for GestureFlingStar..." (Closed)

Created:
6 years, 10 months ago by jdduke (slow)

Modified:
6 years, 10 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

More Reviews

Description

Merge 251963 "[Android] Use DIP coordinates for GestureFlingStar..." > [Android] Use DIP coordinates for GestureFlingStart events > > The OverScroller used to generate fling updates on Android works in pixel space. > Consequently, GestureFlingStart velocities were forwarded also in pixel space. > This exceptional case is unnecessary and confusing, as all other gestures > components are provided as DIPs. Adopt DIPs for GestureFlingStart, instead > scaling the velocity to pixels when generating the OverScroller object. > > BUG=332418 > > Review URL: https://codereview.chromium.org/170993003 TBR=jdduke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252977

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	webkit/child/fling_animator_impl_android.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r252977.

Expand Messages | Collapse Messages