core/src/fxcrt/fx_basic_buffer.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_buffer.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: remove cast change on security_handler file Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/fx_basic_buffer.cpp

diff --git a/core/src/fxcrt/fx_basic_buffer.cpp b/core/src/fxcrt/fx_basic_buffer.cpp

index f623d995c783d7a517978b3a11e56e2950435f1a..a3039f4188bd61e032dea4ed9c41f9b78711faa9 100644

--- a/core/src/fxcrt/fx_basic_buffer.cpp

+++ b/core/src/fxcrt/fx_basic_buffer.cpp

@@ -381,7 +381,7 @@ bool CFX_FileBufferArchive::Flush() {

return false;

if (!m_pBuffer || !nRemaining)

return true;

- return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining);

+ return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining) > 0;

}

int32_t CFX_FileBufferArchive::AppendBlock(const void* pBuf, size_t size) {

« no previous file with comments | « core/src/fpdfdoc/doc_formfield.cpp ('k') | core/src/fxcrt/fx_basic_wstring.cpp » ('j') | no next file with comments »