fpdfsdk/src/javascript/Field.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/Field.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/Field.cpp

diff --git a/fpdfsdk/src/javascript/Field.cpp b/fpdfsdk/src/javascript/Field.cpp

index 35ef8b42daf49c3cfa68ee6d48dac4e88d250842..2a814ac6b232075b01edf2761aa84a7a9f1ed50d 100644

--- a/fpdfsdk/src/javascript/Field.cpp

+++ b/fpdfsdk/src/javascript/Field.cpp

@@ -3022,7 +3022,7 @@ FX_BOOL Field::checkThisBox(IJS_Context* cc,

int nWidget = params[0].ToInt();

- FX_BOOL bCheckit = TRUE;

+ bool bCheckit = true;

if (iSize >= 2)

bCheckit = params[1].ToBool();

@@ -3037,9 +3037,9 @@ FX_BOOL Field::checkThisBox(IJS_Context* cc,

if (nWidget < 0 || nWidget >= pFormField->CountControls())

return FALSE;

if (pFormField->GetFieldType() == FIELDTYPE_RADIOBUTTON)

- pFormField->CheckControl(nWidget, bCheckit, TRUE);

+ pFormField->CheckControl(nWidget, bCheckit, true);

else

- pFormField->CheckControl(nWidget, bCheckit, TRUE);

+ pFormField->CheckControl(nWidget, bCheckit, true);

Tom Sepez 2016/03/11 00:30:29 Same on either branch?

Wei Li 2016/03/11 04:11:36 A couple places like this. Add TODOs to check whet

UpdateFormField(m_pDocument, pFormField, TRUE, TRUE, TRUE);

return TRUE;

« fpdfsdk/src/javascript/Document.cpp ('K') | « fpdfsdk/src/javascript/Document.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp » ('j') | no next file with comments »