fpdfsdk/src/formfiller/FFL_CheckBox.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_CheckBox.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/src/fxge/ge/fx_ge_fontmap.cpp ('K') | « fpdfsdk/include/pdfwindow/PWL_SpecialButton.h ('k') | fpdfsdk/src/formfiller/FFL_RadioButton.cpp » ('j') | fpdfsdk/src/javascript/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: fpdfsdk/src/formfiller/FFL_CheckBox.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_CheckBox.cpp b/fpdfsdk/src/formfiller/FFL_CheckBox.cpp

index 78a689af64fd36ccea4e56a8bcd16ca45682aac7..485f86ba7580c2f5c910a19cc3a4090740d1ce18 100644

--- a/fpdfsdk/src/formfiller/FFL_CheckBox.cpp

+++ b/fpdfsdk/src/formfiller/FFL_CheckBox.cpp

@@ -96,7 +96,7 @@ FX_BOOL CFFL_CheckBox::IsDataChanged(CPDFSDK_PageView* pPageView) {

void CFFL_CheckBox::SaveData(CPDFSDK_PageView* pPageView) {

if (CPWL_CheckBox* pWnd = (CPWL_CheckBox*)GetPDFWindow(pPageView, FALSE)) {

- FX_BOOL bNewChecked = pWnd->IsChecked();

+ bool bNewChecked = pWnd->IsChecked();

if (bNewChecked) {

CPDF_FormField* pField = m_pWidget->GetFormField();

@@ -109,7 +109,7 @@ void CFFL_CheckBox::SaveData(CPDFSDK_PageView* pPageView) {

}

- m_pWidget->SetCheck(bNewChecked, FALSE);

+ m_pWidget->SetCheck(bNewChecked, false);

m_pWidget->UpdateField();

SetChangeMark();

}