Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3882)

Unified Diff: core/include/fxcrt/fx_ext.h

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/include/fxcrt/fx_ext.h
diff --git a/core/include/fxcrt/fx_ext.h b/core/include/fxcrt/fx_ext.h
index 689d8e8fc4bd185d6cab5f5672ebe4d9107503db..a5bccb57b5171f3102fbe6da05149ca22a3a5f91 100644
--- a/core/include/fxcrt/fx_ext.h
+++ b/core/include/fxcrt/fx_ext.h
@@ -60,11 +60,11 @@ inline int FXSYS_toHexDigit(const FX_CHAR c) {
}
inline bool FXSYS_isDecimalDigit(const FX_CHAR c) {
- return std::isdigit(c);
+ return std::isdigit(c) != 0;
Tom Sepez 2016/03/11 00:30:28 nit: prefer !!std::isdigit(c) also below.
Wei Li 2016/03/11 04:11:36 Done.
}
inline bool FXSYS_isDecimalDigit(const FX_WCHAR c) {
- return std::iswdigit(c);
+ return std::iswdigit(c) != 0;
}
inline int FXSYS_toDecimalDigit(const FX_CHAR c) {

Powered by Google App Engine
This is Rietveld 408576698