Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1783010: GTK: more signal handler foolproofing. (Closed)

Created:
10 years, 7 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony, Elliot Glaysher
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

GTK: more signal handler foolproofing. BUG=40735 TEST=manual clicking about, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -110 lines) Patch
M chrome/browser/gtk/browser_actions_toolbar_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.cc View 8 chunks +21 lines, -26 lines 0 comments Download
M chrome/browser/gtk/fullscreen_exit_bubble_gtk.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc View 3 chunks +10 lines, -23 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/gtk/menu_bar_helper.h View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/gtk/menu_bar_helper.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/rounded_window.cc View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
10 years, 7 months ago (2010-04-28 22:33:52 UTC) #1
Elliot Glaysher
10 years, 7 months ago (2010-04-28 22:46:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698