Using "override" to explicitly annotate overrides of virtual functions.

Using "override" to explicitly annotate overrides of virtual functions.

This CL improves compliance with Google C++ Style Guide:
https://google.github.io/styleguide/cppguide.html:

    Explicitly annotate overrides of virtual functions or virtual
    destructors with an override or (less frequently) final specifier. Older
    (pre-C++11) code will use the virtual keyword as an inferior alternative
    annotation. For clarity, use exactly one of override, final, or virtual
    when declaring an override.  Rationale: A function or destructor marked
    override or final that is not an override of a base class virtual
    function will not compile, and this helps catch common errors. The
    specifiers serve as documentation; if no specifier is present, the
    reader has to check all ancestors of the class in question to determine
    if the function or destructor is virtual or not.

BUG=

Committed: https://crrev.com/264b0e5be5267ddd0cbf4ea6bc62df961e492697
Cr-Commit-Position: refs/heads/master@{#380658}

[Łukasz Anforowicz, 2016-03-11 00:25:28]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-11 00:25:29]

jochen@, can you rubberstamp this one please?  This CL mechanically changes
virtual -> override (+ follows-up with git cl format).

I did this CL, because I was initially confused and thought that WebTestProxy
inherits from WebViewClient but tries to override methods of WebFrameClient (I
was confused because I was looking at WebTestProxyBase when I thought that I am
looking at WebTestProxy).

At any rate, it is interesting that we have test implementations of
WebFrameClient and WebViewClient both funnel the calls into WebTestProxyBase
(which consequently ends up sending PrintMessage IPCs via
WebTestDelegate/RVO/BlinkTestRunner).  Maybe having a splitting WebTestProxyBase
into Frame- and View-specific parts would help send PrintMessage IPCs via RFO
(instead of RVO) and therefore avoid the swapped_out_messages.cc layering
fiasco.

[Łukasz Anforowicz, 2016-03-11 00:25:40]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 00:26:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783003004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783003004/1

[commit-bot: I haz the power, 2016-03-11 01:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:26:37]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-03-11 14:26:42]

lgtm

[Łukasz Anforowicz, 2016-03-11 17:12:58]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-11 17:13:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783003004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783003004/1

[commit-bot: I haz the power, 2016-03-11 17:19:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 17:20:29]

Description was changed from

==========
Using "override" to explicitly annotate overrides of virtual functions.

This CL improves compliance with Google C++ Style Guide:
https://google.github.io/styleguide/cppguide.html:

    Explicitly annotate overrides of virtual functions or virtual
    destructors with an override or (less frequently) final specifier. Older
    (pre-C++11) code will use the virtual keyword as an inferior alternative
    annotation. For clarity, use exactly one of override, final, or virtual
    when declaring an override.  Rationale: A function or destructor marked
    override or final that is not an override of a base class virtual
    function will not compile, and this helps catch common errors. The
    specifiers serve as documentation; if no specifier is present, the
    reader has to check all ancestors of the class in question to determine
    if the function or destructor is virtual or not.

BUG=
==========

to

==========
Using "override" to explicitly annotate overrides of virtual functions.

This CL improves compliance with Google C++ Style Guide:
https://google.github.io/styleguide/cppguide.html:

    Explicitly annotate overrides of virtual functions or virtual
    destructors with an override or (less frequently) final specifier. Older
    (pre-C++11) code will use the virtual keyword as an inferior alternative
    annotation. For clarity, use exactly one of override, final, or virtual
    when declaring an override.  Rationale: A function or destructor marked
    override or final that is not an override of a base class virtual
    function will not compile, and this helps catch common errors. The
    specifiers serve as documentation; if no specifier is present, the
    reader has to check all ancestors of the class in question to determine
    if the function or destructor is virtual or not.

BUG=

Committed: https://crrev.com/264b0e5be5267ddd0cbf4ea6bc62df961e492697
Cr-Commit-Position: refs/heads/master@{#380658}
==========

[commit-bot: I haz the power, 2016-03-11 17:20:30]

Patchset 1 (id:??) landed as
https://crrev.com/264b0e5be5267ddd0cbf4ea6bc62df961e492697
Cr-Commit-Position: refs/heads/master@{#380658}