sdk/lib/_collection_dev/iterable.dart - Issue 17830002: Test equality argument order in iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_collection_dev/iterable.dart

Issue 17830002: Test equality argument order in iterable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_collection_dev/iterable.dart

diff --git a/sdk/lib/_collection_dev/iterable.dart b/sdk/lib/_collection_dev/iterable.dart

index 53b297fed022b7dc9d4edcac12ec6daff9bd1ae5..a33b4a0675e9599a1fbad983351d922757fdcbe5 100644

--- a/sdk/lib/_collection_dev/iterable.dart

+++ b/sdk/lib/_collection_dev/iterable.dart

@@ -694,7 +694,7 @@ abstract class BidirectionalIterator<T> implements Iterator<T> {

class IterableMixinWorkaround {

static bool contains(Iterable iterable, var element) {

for (final e in iterable) {

- if (element == e) return true;

+ if (e == element) return true;

}

return false;

}

« no previous file with comments | « no previous file | tests/corelib/list_contains_argument_order_test.dart » ('j') | no next file with comments »