Test equality argument order in iterable.

tests/corelib/list_contains_argument_order_test.dart

Index: tests/corelib/list_contains_argument_order_test.dart
diff --git a/tests/corelib/list_contains_argument_order_test.dart b/tests/corelib/list_contains_argument_order_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..85f97825101aaa6467ea789344f3c91d691ecbd1
--- /dev/null
+++ b/tests/corelib/list_contains_argument_order_test.dart
@@ -0,0 +1,42 @@
+import "package:expect/expect.dart";

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Add missing copyright header (remember to update year if copying it from a file
that doesn't say 2013).

[zarah, 2013/06/26 09:08:34]

Done.

+
+bool a;
+
+class A {
+  bool operator ==(A other) {
+    a = true;
+    return false;
+  }
+}
+
+class B {
+  bool operator ==(B other) {
+    throw new Exception('Bad equality order.');

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Change line to:
 Expect.fail("Bad equality order.");

You have imported expect.dart, might as well use it.

[zarah, 2013/06/26 09:08:34]

Done.

+  }
+}
+
+main() {
+  var list = <A>[new A() ];

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Add space between '[' and 'new'.

[zarah, 2013/06/26 09:08:34]

Done.

+  var list2 = new List<A>(1);

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

You can use cascade notation to initialize on the same line;
  var list2 = new List<A>(1)..[0] = new A();
  var list3 = new List<A>()..add(new A());

[zarah, 2013/06/26 09:08:34]

Done.

+  list2[0] = new A();
+  var list3 = new List<A>();
+  list3.add(new A());
+  var list4 = <A>[new A() ];
+  var iterable = list.map((x) => x);
+  var iterable2 = list.take(1);

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

If you want to do this for each iterable, do it inside the loop instead. I.e.,
remove these and inside the loop add:

  a = false;
  iterable.map((x) => x).contains(new B());
  Expect.isTrue(a);

  a = false;
  iterable.take(1).contains(new B());
  Expect.isTrue(a);

and then only have the base iterables in the "iterables" list.

If you don't like duplicate code (and who does?) make a helper function:
  test(iterable) {
    a = false
    Expect.isFalse(iterable.contains(new B()));
    Expect.isTrue(a);
  }
and inside the loop just do:
  test(iterable)
  test(iterable.map((x) => x));
  test(iterable.take(1));
... and it's easy to add more if you want it.

[zarah, 2013/06/26 09:08:34]

Done.

+  var iterable3 = list2.map((x) => x);
+  var iterable4 = list2.take(1);
+  var iterable5 = list3.map((x) => x);
+  var iterable6 = list3.take(1);
+  var iterable7 = list4.map((x) => x);
+  var iterable8 = list4.take(1);

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Try a Set, Map.keys, and Map.values as well:

  var iterable9 = new Set()..add(new A());
  var iterable10 = (new Map()..[new A()] = 0).keys;
  var iterable11 = (new Map()..[0] = new A()).values;

[zarah, 2013/06/26 09:08:34]

Done.

+
+  var iterables =
+      [list, list2, list3, list4, iterable, iterable2, iterable3,
+      iterable4, iterable5, iterable6, iterable7, iterable8];

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Now that you can have each iterable created on a single line, you could do this
as one long literal, instead of having the intermediate variables:
  var iterables = [
      <A>[ new A() ],
      new List<A>(1)..[0] = new A(),
      ...
      (new Map()..[0] = new A()).values
  ];

Only change this if you think it's easier to read (but you will avoid a lot of
names!).

[zarah, 2013/06/26 09:08:34]

Done.

+  for (var iterable in iterables) {
+   a = false;

[Lasse Reichstein Nielsen, 2013/06/26 08:26:59]

Indentation is off-by-one (should be indented one more).

[zarah, 2013/06/26 09:08:34]

Done.

+   iterable.contains(new B());
+   Expect.isTrue(a);
+  }
+}