Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1782983002: Fix deps in shell (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix deps in shell TBR=sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7c3be1c7f177752169cee10118aca286d086d658 Cr-Commit-Position: refs/heads/master@{#380452}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/mojo_shell.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782983002/40001
4 years, 9 months ago (2016-03-10 20:05:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782983002/40001
4 years, 9 months ago (2016-03-10 20:09:25 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 20:09:53 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 20:10:55 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7c3be1c7f177752169cee10118aca286d086d658
Cr-Commit-Position: refs/heads/master@{#380452}

Powered by Google App Engine
This is Rietveld 408576698