tests/PictureTest.cpp - Issue 1782973002: Revert of Use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 1782973002: Revert of Use std::unique_ptr. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index a33deeb218689193ecedfa3dd8fd0a8fc19c154d..448e079958ef5a01444fc0c5a9b009c16325b27e 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -1409,7 +1409,7 @@

SkAutoTDelete<SkStream> rstream(wstream.detachAsStream());

SkAutoTUnref<SkPicture> deserializedPicture(SkPicture::CreateFromStream(rstream));

- REPORTER_ASSERT(r, deserializedPicture != nullptr);

+ REPORTER_ASSERT(r, SkToBool(deserializedPicture));

REPORTER_ASSERT(r, deserializedPicture->cullRect().left() == 1);

REPORTER_ASSERT(r, deserializedPicture->cullRect().top() == 2);

REPORTER_ASSERT(r, deserializedPicture->cullRect().right() == 3);

« no previous file with comments | « tests/ClearTest.cpp ('k') | tests/ResourceCacheTest.cpp » ('j') | no next file with comments »