Remove std::mem_fun uses.

Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407
Committed: https://crrev.com/ad1b44e489281f42a0ea6d7d9516ba30d5879225
Cr-Commit-Position: refs/heads/master@{#380740}

[vmpstr, 2016-03-10 19:29:36]

vmpstr@chromium.org changed reviewers:
+ thakis@chromium.org

[vmpstr, 2016-03-10 19:29:37]

Please take a look.

[Nico, 2016-03-10 19:52:11]

the trybots hate this.

Also, maybe link to the cxx@ discussion for context.

[vmpstr, 2016-03-10 20:46:46]

On 2016/03/10 19:52:11, Nico wrote:
> the trybots hate this.
> 
> Also, maybe link to the cxx@ discussion for context.

Hmm, apparently my local build didn't bother building the chromeos changes.
Whoops, I'll come back again.

[vmpstr, 2016-03-10 22:15:02]

Description was changed from

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

BUG=593407
==========

to

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

BUG=593407
==========

[vmpstr, 2016-03-10 22:16:09]

On 2016/03/10 20:46:46, vmpstr wrote:
> On 2016/03/10 19:52:11, Nico wrote:
> > the trybots hate this.
> > 
> > Also, maybe link to the cxx@ discussion for context.
> 
> Hmm, apparently my local build didn't bother building the chromeos changes.
> Whoops, I'll come back again.

Ok, I think this should be better. PTAL. Also, I wasn't sure which discussion
you wanted me to reference, so I put the one where I wanna ban std::mem_fn,
since that seems the most related.

[Nico, 2016-03-10 22:23:19]

I meant the "Is std::mem_fn allowed?" thread on cxx@

https://codereview.chromium.org/1782963002/diff/20001/chrome/browser/browsing...
File chrome/browser/browsing_data/cookies_tree_model.cc (right):

https://codereview.chromium.org/1782963002/diff/20001/chrome/browser/browsing...
chrome/browser/browsing_data/cookies_tree_model.cc:294:
child->DeleteStoredObjects();
\o/

https://codereview.chromium.org/1782963002/diff/20001/chromeos/dbus/services/...
File chromeos/dbus/services/service_provider_test_helper.cc (right):

https://codereview.chromium.org/1782963002/diff/20001/chromeos/dbus/services/...
chromeos/dbus/services/service_provider_test_helper.cc:69: };
I love all the other changes in this CL, but this one seems bad:

1. It's more code

2. The use of mem_fun is very hidden somewhere in gmock here. Can we change this
in gmock instead? (We've made changes to gmock in the past, it's doable.)

Maybe you can revert the change to this file for now for landing?

[vmpstr, 2016-03-10 22:45:00]

PTAL

> I meant the "Is std::mem_fn allowed?" thread on cxx@

Cool that's the one I referenced.

https://codereview.chromium.org/1782963002/diff/20001/chromeos/dbus/services/...
File chromeos/dbus/services/service_provider_test_helper.cc (right):

https://codereview.chromium.org/1782963002/diff/20001/chromeos/dbus/services/...
chromeos/dbus/services/service_provider_test_helper.cc:69: };
On 2016/03/10 22:23:19, Nico wrote:
> I love all the other changes in this CL, but this one seems bad:
> 
> 1. It's more code
> 
> 2. The use of mem_fun is very hidden somewhere in gmock here. Can we change
this
> in gmock instead? (We've made changes to gmock in the past, it's doable.)

I figured that it's probably OK since this is test code :P but yes, I agree that
we should probably change gmock. Jeffrey also suggested something similar on the
discussion thread.

> 
> Maybe you can revert the change to this file for now for landing?

That sounds good. Done.

[Nico, 2016-03-10 22:50:39]

lgtm

[vmpstr, 2016-03-10 22:53:39]

vmpstr@chromium.org changed reviewers:
+ gavinp@chromium.org, sievers@chromium.org, tzik@chromium.org

[vmpstr, 2016-03-10 22:53:40]

+sievers for content/
+gavinp for net/disk_cache/simple/
+tzik for storage/browser/quota/

Please take a look.

[vmpstr, 2016-03-10 23:53:50]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[no sievers, 2016-03-10 23:54:00]

On 2016/03/10 22:53:40, vmpstr wrote:
> +sievers for content/
> +gavinp for net/disk_cache/simple/
> +tzik for storage/browser/quota/
> 
> Please take a look.

content lgtm

[commit-bot: I haz the power, 2016-03-10 23:54:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782963002/40001

[commit-bot: I haz the power, 2016-03-11 00:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:33:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-03-11 03:05:59]

lgtm

[Nico, 2016-03-11 15:16:43]

(i think you can tbr this to gavinp per the 2nd bullet on
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
fwiw)

[vmpstr, 2016-03-11 18:34:37]

Description was changed from

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

BUG=593407
==========

to

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407
==========

[vmpstr, 2016-03-11 18:34:53]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-03-11 18:35:11]

On 2016/03/11 15:16:43, Nico wrote:
> (i think you can tbr this to gavinp per the 2nd bullet on
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
> fwiw)

OK, TBRing gavinp

[commit-bot: I haz the power, 2016-03-11 18:35:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782963002/40001

[gavinp, 2016-03-11 18:50:50]

lgtm, and I agree, TBR was appropriate.

[commit-bot: I haz the power, 2016-03-11 19:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:58:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2016-03-11 21:05:21]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-03-11 21:06:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782963002/40001

[commit-bot: I haz the power, 2016-03-11 21:40:06]

Description was changed from

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407
==========

to

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407
==========

[commit-bot: I haz the power, 2016-03-11 21:40:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-11 21:41:09]

Description was changed from

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407
==========

to

==========
Remove std::mem_fun uses.

This patch removes std::mem_fun and std::mem_fun_ref uses from the
codebase, since those are deprecated in C++11. Additionally, the
resulting code should be simpler to parse, since most of the time the
use is replaced with a ranged based for-loop, which is a more familiar
construct.

Discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ip8T6u-o7KY

TBR=gavinp
BUG=593407

Committed: https://crrev.com/ad1b44e489281f42a0ea6d7d9516ba30d5879225
Cr-Commit-Position: refs/heads/master@{#380740}
==========

[commit-bot: I haz the power, 2016-03-11 21:41:11]

Patchset 3 (id:??) landed as
https://crrev.com/ad1b44e489281f42a0ea6d7d9516ba30d5879225
Cr-Commit-Position: refs/heads/master@{#380740}