Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1782943002: Fixes for Win toolchain isolate (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 9 months ago
Reviewers:
kjlubick, stephana, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@swarm_win_toolchain
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Patch Set 4 : Add win_toolchain_utils #

Patch Set 5 : Add missing win_toolchain.json to isolate #

Patch Set 6 : ? #

Patch Set 7 : Make flag more descriptive #

Patch Set 8 : Update toolchain hashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -5 lines) Patch
A infra/bots/bootstrap_win_toolchain_json.py View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M infra/bots/isolate_win_toolchain.py View 1 2 3 4 chunks +17 lines, -2 lines 0 comments Download
M infra/bots/win_toolchain.isolate View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M infra/bots/win_toolchain_hash.json View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
A infra/bots/win_toolchain_utils.py View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
borenet
4 years, 9 months ago (2016-03-10 21:05:00 UTC) #5
stephana
On 2016/03/10 21:05:00, borenet wrote: lgtm
4 years, 9 months ago (2016-03-10 21:09:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782943002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782943002/140001
4 years, 9 months ago (2016-03-11 12:53:49 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 12:54:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/2f56b1aba22ad79a5e63587e4bca3001ab7ab0ba

Powered by Google App Engine
This is Rietveld 408576698