Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only used for DNG for…

Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782913002

Committed: https://skia.googlesource.com/skia/+/7a307df926da2afbdadfb36250925c7f76e3493a

[yujieqin, 2016-03-10 16:47:02]

Description was changed from

==========
Rename the kRAW_SkEncodedFormat to kRAW_DNG_SkEncodedFormat as it is actually
only used for DNG format

BUG=b/27587823
==========

to

==========
Rename the kRAW_SkEncodedFormat to kRAW_DNG_SkEncodedFormat as it is actually
only used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[yujieqin, 2016-03-10 16:47:34]

Description was changed from

==========
Rename the kRAW_SkEncodedFormat to kRAW_DNG_SkEncodedFormat as it is actually
only used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Rename the kRAW_SkEncodedFormat to kRAW_DNG_SkEncodedFormat as it is actually
only used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[yujieqin, 2016-03-10 16:47:34]

yujieqin@google.com changed reviewers:
+ msarett@google.com, scroggo@google.com

[yujieqin, 2016-03-10 16:47:49]

The CQ bit was checked by yujieqin@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 16:47:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782913002/1

[commit-bot: I haz the power, 2016-03-10 16:48:00]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-03-10 22:48 UTC

[scroggo, 2016-03-10 16:51:45]

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp#newcode488
dm/DM.cpp:488: case SkEncodedFormat::kRAW_DNG_SkEncodedFormat:
Does it need "RAW" in the name, or would kDNG_SkEncodedFormat be adequate?

[msarett, 2016-03-10 16:55:40]

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp#newcode488
dm/DM.cpp:488: case SkEncodedFormat::kRAW_DNG_SkEncodedFormat:
On 2016/03/10 16:51:44, scroggo wrote:
> Does it need "RAW" in the name, or would kDNG_SkEncodedFormat be adequate?

+1 for kDNG_SkEncodedFormat

[commit-bot: I haz the power, 2016-03-10 22:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:48:06]

Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[yujieqin, 2016-03-11 11:02:54]

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1782913002/diff/1/dm/DM.cpp#newcode488
dm/DM.cpp:488: case SkEncodedFormat::kRAW_DNG_SkEncodedFormat:
On 2016/03/10 16:55:40, msarett wrote:
> On 2016/03/10 16:51:44, scroggo wrote:
> > Does it need "RAW" in the name, or would kDNG_SkEncodedFormat be adequate?
> 
> +1 for kDNG_SkEncodedFormat

Done.

[scroggo, 2016-03-11 14:15:19]

> Rename the kRAW_SkEncodedFormat to
> kRAW_DNG_SkEncodedFormat as it is actually only used for
> DNG format

Please update the description to say "kDNG_SkEncodedFormat".

Otherwise lgtm

[scroggo, 2016-03-11 14:16:49]

https://codereview.chromium.org/1782913002/diff/20001/tools/get_images_from_s...
File tools/get_images_from_skps.cpp (right):

https://codereview.chromium.org/1782913002/diff/20001/tools/get_images_from_s...
tools/get_images_from_skps.cpp:53: case SkEncodedFormat::kDNG_SkEncodedFormat:
ext =  "dng"; break;
nit: this should line up with the others.

[yujieqin, 2016-03-11 14:28:17]

Description was changed from

==========
Rename the kRAW_SkEncodedFormat to kRAW_DNG_SkEncodedFormat as it is actually
only used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only
used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[yujieqin, 2016-03-11 14:33:15]

https://codereview.chromium.org/1782913002/diff/20001/tools/get_images_from_s...
File tools/get_images_from_skps.cpp (right):

https://codereview.chromium.org/1782913002/diff/20001/tools/get_images_from_s...
tools/get_images_from_skps.cpp:53: case SkEncodedFormat::kDNG_SkEncodedFormat:
ext =  "dng"; break;
On 2016/03/11 14:16:48, scroggo wrote:
> nit: this should line up with the others.

Done.

[yujieqin, 2016-03-11 14:33:26]

The CQ bit was checked by yujieqin@google.com

[yujieqin, 2016-03-11 14:33:26]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1782913002/#ps40001
(title: "Fix code formatting")

[commit-bot: I haz the power, 2016-03-11 14:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782913002/40001

[commit-bot: I haz the power, 2016-03-11 14:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 14:35:08]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-03-11 14:36:00]

msarett@google.com changed reviewers:
+ djsollen@google.com

[msarett, 2016-03-11 14:36:01]

Adding Derek for an API review.

[djsollen, 2016-03-11 15:12:05]

lgtm

[yujieqin, 2016-03-11 15:31:27]

The CQ bit was checked by yujieqin@google.com

[commit-bot: I haz the power, 2016-03-11 15:31:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782913002/40001

[commit-bot: I haz the power, 2016-03-11 15:32:35]

Description was changed from

==========
Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only
used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only
used for DNG format

BUG=b/27587823
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7a307df926da2afbdadfb36250925c7f76e3493a
==========

[commit-bot: I haz the power, 2016-03-11 15:32:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7a307df926da2afbdadfb36250925c7f76e3493a