Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Issue 1782903002: exclude src/ports/*CG* for all targets (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

exclude src/ports/*CG* for all targets We were not excluding it from iOS builds, which fails including MobileCoreServices.h. (Odd!) Also remove some redudant exclusions of src/ports/SkImageDecoder_CG.cpp, and sorts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782903002 Committed: https://skia.googlesource.com/skia/+/3f193a9b9b6fc034f5eb83af973c4c4e4f2dfe26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M public.bzl View 6 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 9 months ago (2016-03-10 16:41:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782903002/1
4 years, 9 months ago (2016-03-10 16:41:30 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-10 16:41:31 UTC) #6
msarett
lgtm
4 years, 9 months ago (2016-03-10 16:43:31 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 16:52:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3f193a9b9b6fc034f5eb83af973c4c4e4f2dfe26

Powered by Google App Engine
This is Rietveld 408576698