Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1782893002: [Interpreter] Fixes cctest/test-serialize/SerializeInternalReference for ignition. (Closed)

Created:
4 years, 9 months ago by mythria
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes cctest/test-serialize/SerializeInternalReference for ignition. Updates cctest.status and also updates the test cctest/test-serialize/SerializeInternalReference to return success when FLAG_ignition is true. This test tests for internal references and is not relevant for interpreter. BUG=v8:4280, v8:4680 LOG=N Committed: https://crrev.com/d1e3b72edeec97058c74e8d25d8a9b25767f7b53 Cr-Commit-Position: refs/heads/master@{#34723}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +13 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782893002/1
4 years, 9 months ago (2016-03-10 16:25:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2721) v8_linux_arm_rel on ...
4 years, 9 months ago (2016-03-10 16:26:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782893002/20001
4 years, 9 months ago (2016-03-11 10:34:17 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 11:07:56 UTC) #9
mythria
PTAL Thanks, Mythri
4 years, 9 months ago (2016-03-11 11:14:00 UTC) #11
rmcilroy
LGTM. +Yang as FYI.
4 years, 9 months ago (2016-03-11 11:30:40 UTC) #13
Yang
On 2016/03/11 11:30:40, rmcilroy wrote: > LGTM. +Yang as FYI. lgtm.
4 years, 9 months ago (2016-03-11 11:41:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782893002/20001
4 years, 9 months ago (2016-03-11 13:34:10 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 13:35:47 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 13:35:55 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1e3b72edeec97058c74e8d25d8a9b25767f7b53
Cr-Commit-Position: refs/heads/master@{#34723}

Powered by Google App Engine
This is Rietveld 408576698