Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1782863002: [turbofan] Change the way nodes with multiple outputs are verified. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change the way nodes with multiple outputs are verified. With the original implementation nodes which were not reachable from end could cause the verification to fail. R=titzer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/d30af81ecf134e86cc41c113ea9068e16f2894dd Cr-Commit-Position: refs/heads/master@{#34683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/compiler/verifier.cc View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ahaas
4 years, 9 months ago (2016-03-10 15:09:44 UTC) #1
Jarin
lgtm. Thanks!
4 years, 9 months ago (2016-03-10 15:25:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782863002/1
4 years, 9 months ago (2016-03-10 15:27:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:37:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d30af81ecf134e86cc41c113ea9068e16f2894dd Cr-Commit-Position: refs/heads/master@{#34683}
4 years, 9 months ago (2016-03-10 15:39:20 UTC) #8
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-10 16:03:04 UTC) #9
titzer
4 years, 9 months ago (2016-03-10 16:04:13 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698