Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1782843002:
[Coverage] Enable merging coverage data from swarming. (Closed)
|
Created:
4 years, 9 months ago by Michael Achenbach Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Coverage] Enable merging coverage data from swarming.
This adds a function to the sancov_merger that merges the
output files of one swarming shard in parallel. This will
be called from the infrastructure when collecting/merging
swarming results.
The tool will be called subsequently for each shard. On
the first call, the target dir will be empty and the sancov
files will just be moved.
BUG=chromium:568949
LOG=n
NOTRY=true
Committed: https://crrev.com/6e401f20659a1a41b379d699176b03cef10c9959
Cr-Commit-Position: refs/heads/master@{#34678}
Patch Set 1 : Extract old functionality #Patch Set 2 : Fixes #Patch Set 3 : Implement swarming merge #
Total comments: 4
Messages
Total messages: 18 (8 generated)
Description was changed from ========== [Coverage] Enable merging coverage data from swarming. BUG= ========== to ========== [Coverage] Enable merging coverage data from swarming. BUG=chromium:568949 LOG=n NOTRY=true TBR=kjellander@chromium.org, tandrii@chromium.org ==========
machenbach@chromium.org changed reviewers: + kjellander@chromium.org, tandrii@chromium.org
Description was changed from ========== [Coverage] Enable merging coverage data from swarming. BUG=chromium:568949 LOG=n NOTRY=true TBR=kjellander@chromium.org, tandrii@chromium.org ========== to ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true TBR=kjellander@chromium.org, tandrii@chromium.org ==========
Description was changed from ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true TBR=kjellander@chromium.org, tandrii@chromium.org ========== to ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true ==========
PTAL
machenbach@chromium.org changed reviewers: + hablich@chromium.org
+ hablich
https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... File tools/sanitizers/sancov_merger.py (right): https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... tools/sanitizers/sancov_merger.py:119: def merge_parallel(inputs, merge_fun=merge): nit: I would simply call it merge_function ... I wondered why there is fun in a merge :-).
lgtm
https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... File tools/sanitizers/sancov_merger.py (right): https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... tools/sanitizers/sancov_merger.py:119: def merge_parallel(inputs, merge_fun=merge): On 2016/03/10 14:39:08, Hablich wrote: > nit: I would simply call it merge_function ... I wondered why there is fun in a > merge :-). Laziness. fun is commonly used as abbreviation for function.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782843002/40001
Message was sent while issue was closed.
Description was changed from ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true ========== to ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true ========== to ========== [Coverage] Enable merging coverage data from swarming. This adds a function to the sancov_merger that merges the output files of one swarming shard in parallel. This will be called from the infrastructure when collecting/merging swarming results. The tool will be called subsequently for each shard. On the first call, the target dir will be empty and the sancov files will just be moved. BUG=chromium:568949 LOG=n NOTRY=true Committed: https://crrev.com/6e401f20659a1a41b379d699176b03cef10c9959 Cr-Commit-Position: refs/heads/master@{#34678} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6e401f20659a1a41b379d699176b03cef10c9959 Cr-Commit-Position: refs/heads/master@{#34678}
Message was sent while issue was closed.
lgtm https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... File tools/sanitizers/sancov_merger.py (right): https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... tools/sanitizers/sancov_merger.py:199: logging.info('Executing %d merge jobs in parallel.' % len(inputs)) nit: s/%/, because logging does formatting for you:)
Message was sent while issue was closed.
https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... File tools/sanitizers/sancov_merger.py (right): https://codereview.chromium.org/1782843002/diff/40001/tools/sanitizers/sancov... tools/sanitizers/sancov_merger.py:199: logging.info('Executing %d merge jobs in parallel.' % len(inputs)) On 2016/03/10 15:40:06, tandrii(chromium) wrote: > nit: s/%/, > because logging does formatting for you:) Ah right, didn't pay attention. Will clean up all call sites in a follow up. |
