Add paint() function as valid CSS <image> type.

Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252
Committed: https://crrev.com/7cc9d3b1f854d212f0f5f2f2a4c3cf73c1c5ad4b
Cr-Commit-Position: refs/heads/master@{#381068}

[ikilpatrick, 2016-03-14 00:27:21]

Description was changed from

==========
CSS Property Parser paint() function

BUG=
==========

to

==========
Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252
==========

[ikilpatrick, 2016-03-14 00:27:48]

ikilpatrick@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-03-14 00:43:55]

On 2016/03/14 00:27:49, ikilpatrick wrote:

lgtm

Would be nice to have tests, but if the flag is permanently off I guess it's
fine to not have any for now. I don't have Source/platform OWNERS so you'll need
to get someone else for that file.

[Timothy Loh, 2016-03-14 00:45:52]

https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPaintValue.cpp (right):

https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPaintValue.cpp:27: result.append(name());
Actually this probably needs to be m_name->customCSSText() since custom idents
can be written with escapes in custom idents, e.g. paint(\ ) would be serialized
as paint( ) with the current code.

[Timothy Loh, 2016-03-14 00:45:55]

lgtm

[ikilpatrick, 2016-03-14 17:41:45]

ikilpatrick@chromium.org changed reviewers:
+ leviw@chromium.org

[ikilpatrick, 2016-03-14 17:41:46]

+levi for platform

I'm working on a large patch which hooks everything up, tests will be in that
once I flip this flag to 'test'.

Thanks for the review :)

https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPaintValue.cpp (right):

https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPaintValue.cpp:27: result.append(name());
On 2016/03/14 00:45:52, Timothy Loh wrote:
> Actually this probably needs to be m_name->customCSSText() since custom idents
> can be written with escapes in custom idents, e.g. paint(\ ) would be
serialized
> as paint( ) with the current code.

Done.

[leviw_travelin_and_unemployed, 2016-03-14 17:54:50]

On 2016/03/14 at 17:41:46, ikilpatrick wrote:
> +levi for platform
> 
> I'm working on a large patch which hooks everything up, tests will be in that
once I flip this flag to 'test'.

Got it. Coolio.

I've got your platform right *here*!

lgtm for that extremely invasive change.

> 
> Thanks for the review :)
> 
>
https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/CSSPaintValue.cpp (right):
> 
>
https://codereview.chromium.org/1782833008/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/CSSPaintValue.cpp:27:
result.append(name());
> On 2016/03/14 00:45:52, Timothy Loh wrote:
> > Actually this probably needs to be m_name->customCSSText() since custom
idents
> > can be written with escapes in custom idents, e.g. paint(\ ) would be
serialized
> > as paint( ) with the current code.
> 
> Done.

[ikilpatrick, 2016-03-14 19:42:45]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-03-14 19:42:45]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1782833008/#ps80001
(title: "name->customCSSText")

[commit-bot: I haz the power, 2016-03-14 19:43:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782833008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782833008/80001

[commit-bot: I haz the power, 2016-03-14 20:56:25]

Description was changed from

==========
Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252
==========

to

==========
Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252
==========

[commit-bot: I haz the power, 2016-03-14 20:56:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-14 20:58:27]

Description was changed from

==========
Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252
==========

to

==========
Add paint() function as valid CSS <image> type.

Enabled behind CSSPaintAPI feature flag.

BUG=578252

Committed: https://crrev.com/7cc9d3b1f854d212f0f5f2f2a4c3cf73c1c5ad4b
Cr-Commit-Position: refs/heads/master@{#381068}
==========

[commit-bot: I haz the power, 2016-03-14 20:58:28]

Patchset 5 (id:??) landed as
https://crrev.com/7cc9d3b1f854d212f0f5f2f2a4c3cf73c1c5ad4b
Cr-Commit-Position: refs/heads/master@{#381068}