Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1782833005: Add threshold for V8Followup-IdleGC (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add threshold for V8Followup-IdleGC The V8Followup-IdleGC seems to be triggering a lot of GCs with low collection count. BUG=None Committed: https://crrev.com/d2466040fdea5f25406f9c6ac07efab10c46548d Cr-Commit-Position: refs/heads/master@{#380607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
keishi
According to some browsing I did on a costom Chrome build that can count V8Followup-IdleGCs, ...
4 years, 9 months ago (2016-03-11 08:16:01 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-11 08:17:09 UTC) #3
sof
lgtm
4 years, 9 months ago (2016-03-11 08:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782833005/1
4 years, 9 months ago (2016-03-11 08:27:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/187846)
4 years, 9 months ago (2016-03-11 10:47:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782833005/1
4 years, 9 months ago (2016-03-11 11:10:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 12:18:41 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 12:20:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2466040fdea5f25406f9c6ac07efab10c46548d
Cr-Commit-Position: refs/heads/master@{#380607}

Powered by Google App Engine
This is Rietveld 408576698