Issue 17828002: Add Ctrl+(+Shift)+Up/Down key bindings for Windows

Issue 17828002: Add Ctrl+(+Shift)+Up/Down key bindings for Windows (Closed)

Created:
7 years, 6 months ago by yosin_UTC9

Modified:
7 years, 6 months ago

Reviewers:
tkent, leviw_travelin_and_unemployed, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

This patch adds - moveParagraphBackward/movePargraphForward to document.execCommand() - Key bindings (Ctrl+Up/Down) for them for Windows. BUG=38097 R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153120

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2013-06-27T14:27:56 #

Total comments: 2

Patch Set 3 : 2013-06-27T14:50:09 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -0 lines)			Patch
M	LayoutTests/NeverFixTests	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/editing/execCommand/enabling-and-selection-2-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/editing/input/ctrl-up-down.html	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	LayoutTests/editing/input/ctrl-up-down-expected.txt	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/editing/selection/selection-actions.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/EditorClientImpl.cpp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/17828002/diff/1/Source/WebKit/chromium/src/EditorClientImpl.cpp File Source/WebKit/chromium/src/EditorClientImpl.cpp (right): https://codereview.chromium.org/17828002/diff/1/Source/WebKit/chromium/src/EditorClientImpl.cpp#newcode387 Source/WebKit/chromium/src/EditorClientImpl.cpp:387: #if OS(WINDOWS) We usually use same key bindings in ...

7 years, 6 months ago (2013-06-27 04:11:03 UTC) #2

yosin_UTC9

PTAL # Changes since last review - Enable Ctrl+(Shift)+Up/Down key bindings other than Mac. https://codereview.chromium.org/17828002/diff/1/Source/WebKit/chromium/src/EditorClientImpl.cpp ...

7 years, 6 months ago (2013-06-27 05:30:54 UTC) #3

tkent

lgtm with a nit https://codereview.chromium.org/17828002/diff/10001/Source/WebKit/chromium/src/EditorClientImpl.cpp File Source/WebKit/chromium/src/EditorClientImpl.cpp (right): https://codereview.chromium.org/17828002/diff/10001/Source/WebKit/chromium/src/EditorClientImpl.cpp#newcode392 Source/WebKit/chromium/src/EditorClientImpl.cpp:392: #endif This #endif and #if ...

7 years, 6 months ago (2013-06-27 05:33:13 UTC) #4

yosin_UTC9

Thanks for reviewing! Committing... https://codereview.chromium.org/17828002/diff/10001/Source/WebKit/chromium/src/EditorClientImpl.cpp File Source/WebKit/chromium/src/EditorClientImpl.cpp (right): https://codereview.chromium.org/17828002/diff/10001/Source/WebKit/chromium/src/EditorClientImpl.cpp#newcode392 Source/WebKit/chromium/src/EditorClientImpl.cpp:392: #endif On 2013/06/27 05:33:14, tkent ...

7 years, 6 months ago (2013-06-27 05:48:03 UTC) #5

yosin_UTC9

7 years, 6 months ago (2013-06-27 05:52:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r153120 (presubmit successful).

Expand Messages | Collapse Messages