Ash: Implement Toasts

ash/system/toast/toast_manager_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/shell.h"
+#include "ash/system/toast/toast_manager.h"
+#include "ash/test/ash_test_base.h"
+#include "base/run_loop.h"
+
+namespace ash {
+
+// Long duration so the timeout doesn't occur.
+const int64_t kLongLongDuration = INT64_MAX;
+
+class DummyEvent : public ui::Event {
+ public:
+  DummyEvent() : Event(ui::ET_UNKNOWN, base::TimeDelta(), 0) {}
+  ~DummyEvent() override {}
+};
+
+class ToastManagerTest : public test::AshTestBase {
+ public:
+  ToastManagerTest() {}
+  ~ToastManagerTest() override {}
+
+ private:
+  void SetUp() override {
+    test::AshTestBase::SetUp();
+
+    manager_ = Shell::GetInstance()->toast_manager();
+
+    manager_->ResetToastIdForTesting();
+    EXPECT_EQ(0, GetToastId());
+  }
+
+  void TearDown() override { test::AshTestBase::TearDown(); }

[oshima, 2016/03/11 09:40:24]

this isn't necessary

[yoshiki, 2016/03/11 14:30:35]

Done.

+
+ protected:
+  ToastManager* manager() const { return manager_; }
+
+  int GetToastId() const { return manager_->toast_id_for_testing(); }

[oshima, 2016/03/11 09:40:24]

new line

[yoshiki, 2016/03/11 14:30:35]

Done.

+  ToastOverlay* GetCurrentOverlay() const {
+    return manager_->GetCurrentOverlayForTesting();
+  }

[oshima, 2016/03/11 09:40:24]

new line

[yoshiki, 2016/03/11 14:30:34]

Done.

+  void ClickDismissButton() {
+    GetCurrentOverlay()->ClickDismissButtonForTesting(DummyEvent());
+  }
+
+ private:
+  ToastManager* manager_ = nullptr;
+
+  DISALLOW_COPY_AND_ASSIGN(ToastManagerTest);
+};
+
+TEST_F(ToastManagerTest, ShowAndCloseAutomatically) {
+  manager()->Show("DUMMY", 10);
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(1, GetToastId());
+
+  while (GetCurrentOverlay() != nullptr)
+    base::RunLoop().RunUntilIdle();
+}
+
+TEST_F(ToastManagerTest, ShowAndCloseManually) {
+  manager()->Show("DUMMY", kLongLongDuration /* prevent timeout */);
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(1, GetToastId());
+
+  ClickDismissButton();
+
+  while (GetCurrentOverlay() != nullptr)
+    base::RunLoop().RunUntilIdle();
+}

[oshima, 2016/03/11 09:40:24]

can you also add the cases where messages are queued?

[yoshiki, 2016/03/11 14:30:34]

Done.

+
+}  // namespace ash