Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: ui/views/bubble/bubble_delegate_unittest.cc

Issue 1782773002: MacViews: Fix ViewTest.HandleAccelerator by faking window activation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delay the activatableness Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_delegate_unittest.cc
diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc
index 5998d1487b8c405e35cbf22a8edc9293e8e2085e..9b782e852d79ffb05b7ac9a7891706f1e365ba20 100644
--- a/ui/views/bubble/bubble_delegate_unittest.cc
+++ b/ui/views/bubble/bubble_delegate_unittest.cc
@@ -15,10 +15,6 @@
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_observer.h"
-#if defined(OS_MACOSX)
-#include "ui/base/test/scoped_fake_nswindow_focus.h"
-#endif
-
namespace views {
namespace {
@@ -69,12 +65,12 @@ class BubbleDelegateTest : public ViewsTestBase {
return widget;
}
- private:
-#if defined(OS_MACOSX)
- // Ensure tests running in parallel don't steal focus from the Widget on Mac.
- ui::test::ScopedFakeNSWindowFocus fake_focus_;
-#endif
+ void SetUp() override {
+ ViewsTestBase::SetUp();
+ EnableMacFakeWindowActivation();
+ }
+ private:
DISALLOW_COPY_AND_ASSIGN(BubbleDelegateTest);
};

Powered by Google App Engine
This is Rietveld 408576698