Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1782743003: [crankshaft] Support inlining of function calls in tail position (in ES6 sense). (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@tco-crank-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Support inlining of function calls in tail position (in ES6 sense). BUG=v8:4698 LOG=N TBR=bmeurer@chromium.org Committed: https://crrev.com/df694d552448bca451e4ffd406f5446bffb28fd2 Cr-Commit-Position: refs/heads/master@{#34992}

Patch Set 1 : #

Patch Set 2 : Other ports #

Total comments: 7

Patch Set 3 : Addressing comments and fixing redness #

Patch Set 4 : ppc, s390 and x87 ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -89 lines) Patch
M src/crankshaft/arm/lithium-arm.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 2 4 chunks +33 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 9 chunks +31 lines, -33 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 5 chunks +12 lines, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 2 1 chunk +19 lines, -3 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 3 chunks +18 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782743003/40001
4 years, 9 months ago (2016-03-11 13:58:45 UTC) #4
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-11 13:58:59 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2798) v8_linux64_rel_ng_triggered on ...
4 years, 9 months ago (2016-03-11 14:14:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782743003/40001
4 years, 9 months ago (2016-03-21 13:40:28 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/17231)
4 years, 9 months ago (2016-03-21 14:01:38 UTC) #12
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/1782743003/diff/40001/src/crankshaft/hydrogen.cc File src/crankshaft/hydrogen.cc (right): https://codereview.chromium.org/1782743003/diff/40001/src/crankshaft/hydrogen.cc#newcode13153 src/crankshaft/hydrogen.cc:13153: if (syntactic_tail_call_mode == TailCallMode::kAllow) { Can ...
4 years, 9 months ago (2016-03-21 14:06:50 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782743003/60001
4 years, 9 months ago (2016-03-22 13:47:28 UTC) #15
Igor Sheludko
Addressed comments and fixed the redness appeared in patch set 2. PTAL. https://codereview.chromium.org/1782743003/diff/40001/src/crankshaft/hydrogen.cc File src/crankshaft/hydrogen.cc ...
4 years, 9 months ago (2016-03-22 14:08:37 UTC) #16
Michael Starzinger
Yep, still LGTM. Thanks!
4 years, 9 months ago (2016-03-22 14:12:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782743003/80001
4 years, 9 months ago (2016-03-22 14:15:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782743003/80001
4 years, 9 months ago (2016-03-22 14:41:41 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 9 months ago (2016-03-22 14:43:45 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/df694d552448bca451e4ffd406f5446bffb28fd2 Cr-Commit-Position: refs/heads/master@{#34992}
4 years, 9 months ago (2016-03-22 14:44:39 UTC) #29
Deon
This change has a typo in " return AddInstruction(NewUncasted<I>(p1, p2, p3, p4, p5, p6, p7, ...
4 years, 7 months ago (2016-05-20 02:51:38 UTC) #30
Igor Sheludko
4 years, 7 months ago (2016-05-20 05:49:09 UTC) #31
Message was sent while issue was closed.
On 2016/05/20 02:51:38, Deon wrote:
> This change has a typo in " return AddInstruction(NewUncasted<I>(p1, p2, p3,
p4,
> p5, p6, p7, p8, p8));"
> The last parameter should be p9.
> 
> On 2016/03/22 14:44:39, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/df694d552448bca451e4ffd406f5446bffb28fd2
> > Cr-Commit-Position: refs/heads/master@{#34992}

Ouch! Thanks!
Luckily we don't use this function. The fix is on the way:
https://codereview.chromium.org/1998093002/

Powered by Google App Engine
This is Rietveld 408576698