dm/DMReporter.h - Issue 178273002: Let DM run unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMReporter.h

Issue 178273002: Let DM run unit tests. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMReporter.h

diff --git a/dm/DMReporter.h b/dm/DMReporter.h

index 4f4ad432d5186db441b28401f88af11b12c59834..2bb4702178a64ccf043b2ef19e475a770646005a 100644

--- a/dm/DMReporter.h

+++ b/dm/DMReporter.h

@@ -7,7 +7,6 @@

#include "SkTypes.h"

// Used to report status changes including failures. All public methods are threadsafe.

namespace DM {

class Reporter : SkNoncopyable {

@@ -15,15 +14,13 @@ public:

Reporter() : fStarted(0), fFinished(0) {}

void start() { sk_atomic_inc(&fStarted); }

- void finish() { sk_atomic_inc(&fFinished); }

- void fail(SkString name);

+ void finish(SkString name);

+ void fail(SkString msg);

int32_t started() const { return fStarted; }

int32_t finished() const { return fFinished; }

int32_t failed() const;

- void updateStatusLine() const;

void getFailures(SkTArray<SkString>*) const;

private:

« no previous file with comments | « dm/DMGpuTask.cpp ('k') | dm/DMReporter.cpp » ('j') | no next file with comments »