Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1782713002: Timeline: fix exception when clicking on drawer padding with collapsible groups enabled (Closed)

Created:
4 years, 9 months ago by caseq
Modified:
4 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix exception when clicking on drawer padding with collapsible groups enabled also: avoid drawing last group padding shadow when no groups are specified. BUG=592363 Committed: https://crrev.com/c0cecb3e3d9551c8a80937fc9a37c94712d40275 Cr-Commit-Position: refs/heads/master@{#380457}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
caseq
4 years, 9 months ago (2016-03-10 00:56:21 UTC) #2
alph
lgtm
4 years, 9 months ago (2016-03-10 17:29:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782713002/20001
4 years, 9 months ago (2016-03-10 17:30:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-10 20:49:14 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 20:50:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0cecb3e3d9551c8a80937fc9a37c94712d40275
Cr-Commit-Position: refs/heads/master@{#380457}

Powered by Google App Engine
This is Rietveld 408576698