Split off IPDF_CryptoHandler into its own .cpp/.h files

Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a1193aedb8797fcb26f54d7b99e4662ae72e3de9

[Tom Sepez, 2016-03-09 21:53:36]

Description was changed from

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files
==========

to

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a (near) pure-virtual class, now it is named as
IPDF_ to indicate this.
==========

[Tom Sepez, 2016-03-09 22:06:54]

Description was changed from

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a (near) pure-virtual class, now it is named as
IPDF_ to indicate this.
==========

to

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
==========

[Tom Sepez, 2016-03-09 22:09:51]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-03-09 22:09:52]

Dan, next one.

https://codereview.chromium.org/1782673002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1782673002/diff/1/BUILD.gn#newcode878
BUILD.gn:878: "xfa/src/fde/fde_renderdevice.h",
git cl format did this.

[Tom Sepez, 2016-03-09 22:18:33]

Dan, next one.

https://codereview.chromium.org/1782673002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/cpdf_standard_crypto_handler.cpp (left):

https://codereview.chromium.org/1782673002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/cpdf_standard_crypto_handler.cpp:14: struct
PDF_CRYPTOITEM {
Note: unused.

https://codereview.chromium.org/1782673002/diff/60001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1782673002/diff/60001/BUILD.gn#oldcode346
BUILD.gn:346: "core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp",
Note: this now becomes cpdf_standard_crypto_handler.cpp's contents.

[dsinclair, 2016-03-10 01:35:55]

lgtm w/ nit.

https://codereview.chromium.org/1782673002/diff/60001/core/include/fpdfapi/ip...
File core/include/fpdfapi/ipdf_crypto_handler.h (right):

https://codereview.chromium.org/1782673002/diff/60001/core/include/fpdfapi/ip...
core/include/fpdfapi/ipdf_crypto_handler.h:17: virtual ~IPDF_CryptoHandler() {}
nit: Move {} to a .cpp file to avoid chromium-style warning.

[Tom Sepez, 2016-03-10 01:42:09]

https://codereview.chromium.org/1782673002/diff/60001/core/include/fpdfapi/ip...
File core/include/fpdfapi/ipdf_crypto_handler.h (right):

https://codereview.chromium.org/1782673002/diff/60001/core/include/fpdfapi/ip...
core/include/fpdfapi/ipdf_crypto_handler.h:17: virtual ~IPDF_CryptoHandler() {}
On 2016/03/10 01:35:55, dsinclair wrote:
> nit: Move {} to a .cpp file to avoid chromium-style warning.

Done.

[Tom Sepez, 2016-03-10 01:42:20]

Description was changed from

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
==========

to

==========
Split off IPDF_CryptoHandler into its own .cpp/.h files.

CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.

R=dsinclair@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/a1193aedb8797fcb26f54d7b99e4662ae72e...
==========

[Tom Sepez, 2016-03-10 01:42:22]

Committed patchset #6 (id:100001) manually as
a1193aedb8797fcb26f54d7b99e4662ae72e3de9 (presubmit successful).