[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org

Committed: https://crrev.com/81bdd5bca887096575be7d13127095ed56b3d3c4
Cr-Commit-Position: refs/heads/master@{#380287}

[Scott Hess - ex-Googler, 2016-03-09 22:57:23]

put gyp sqlite_recover target in iOS clause

[Scott Hess - ex-Googler, 2016-03-09 22:59:33]

Description was changed from

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

BUG=584407
==========

to

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org
==========

[Scott Hess - ex-Googler, 2016-03-09 22:59:33]

shess@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Scott Hess - ex-Googler, 2016-03-09 23:01:44]

On 2016/03/09 22:57:23, Scott Hess wrote:
> put gyp sqlite_recover target in iOS clause

OK, I believe I've figured this out.  Previously the sqlite_recover target was
global, but only referenced when OS == "ios".  But the waterfall builds some
form of |all|, which apparently can then hit this.  I'm still not exactly
certain _how_, or how it passed the commit-queue and trybots.  So I'm TBR'ing
and will contact sheriffs and monitor the landing.

[Scott Hess - ex-Googler, 2016-03-09 23:05:27]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-09 23:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782633002/20001

[commit-bot: I haz the power, 2016-03-10 01:23:29]

Description was changed from

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org
==========

to

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org
==========

[commit-bot: I haz the power, 2016-03-10 01:23:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-10 01:25:17]

Description was changed from

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org
==========

to

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org

Committed: https://crrev.com/81bdd5bca887096575be7d13127095ed56b3d3c4
Cr-Commit-Position: refs/heads/master@{#380287}
==========

[commit-bot: I haz the power, 2016-03-10 01:25:18]

Patchset 2 (id:??) landed as
https://crrev.com/81bdd5bca887096575be7d13127095ed56b3d3c4
Cr-Commit-Position: refs/heads/master@{#380287}

[tsergeant, 2016-03-10 02:26:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1781973002/ by tsergeant@chromium.org.

The reason for reverting is: Causing compile failures on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29...
https://build.chromium.org/p/chromium.mac/builders/iOS_Device_GN/builds/2630
.

[Scott Hess - ex-Googler, 2016-03-10 18:05:01]

On 2016/03/10 02:26:25, tsergeant wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1781973002/ by mailto:tsergeant@chromium.org.
> 
> The reason for reverting is: Causing compile failures on iOS:
> 
>
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29...
> https://build.chromium.org/p/chromium.mac/builders/iOS_Device_GN/builds/2630
> .

W.  T.  F.