Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: webkit/common/user_agent/user_agent.h

Issue 178263007: Simplify the user agent overriding code, in preparation for moving it out of src/webkit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: review comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/test/webkit_support.cc ('k') | webkit/common/user_agent/user_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_ 5 #ifndef WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_
6 #define WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_ 6 #define WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
tfarina 2014/03/07 00:15:06 remove?
11 #include "url/gurl.h" 11 #include "url/gurl.h"
tfarina 2014/03/07 00:15:06 forward declare?
12 #include "webkit/common/user_agent/webkit_user_agent_export.h" 12 #include "webkit/common/user_agent/webkit_user_agent_export.h"
13 13
14 namespace webkit_glue { 14 namespace webkit_glue {
15 15
16 // Sets the user agent. Pass true for overriding if this is a custom 16 // Sets the user agent. This must be called before GetUserAgent() can
17 // user agent instead of the default one (in order to turn off any browser
18 // sniffing workarounds). This must be called before GetUserAgent() can
19 // be called. 17 // be called.
20 WEBKIT_USER_AGENT_EXPORT void SetUserAgent(const std::string& user_agent, 18 WEBKIT_USER_AGENT_EXPORT void SetUserAgent(const std::string& user_agent);
21 bool overriding);
22 19
23 // Returns the user agent to use for the given URL. SetUserAgent() must 20 // Returns the user agent to use for the given URL. SetUserAgent() must
24 // be called prior to calling this function. 21 // be called prior to calling this function.
25 WEBKIT_USER_AGENT_EXPORT const std::string& GetUserAgent(const GURL& url); 22 WEBKIT_USER_AGENT_EXPORT const std::string& GetUserAgent(const GURL& url);
26 23
27 } // namespace webkit_glue 24 } // namespace webkit_glue
28 25
29 #endif // WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_ 26 #endif // WEBKIT_COMMON_USER_AGENT_USER_AGENT_H_
OLDNEW
« no previous file with comments | « content/test/webkit_support.cc ('k') | webkit/common/user_agent/user_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698