rAc - Only show countries we're able to fill in.

components/autofill/core/browser/form_structure.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
+#include "base/i18n/case_conversion.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 1084 matching lines @@
                                      app_locale,
                                      field(i));
         filled_something = true;
         break;
       }
     }
   }
   return filled_something;
 }
 
+std::set<base::string16> FormStructure::PossibleValues(ServerFieldType type) {
+  std::set<base::string16> values;
+  AutofillType target_type(type);
+  for (std::vector<AutofillField*>::iterator iter = fields_.begin();
+       iter != fields_.end(); ++iter) {
+    AutofillField* field = *iter;
+    if (field->Type().GetStorableType() != target_type.GetStorableType() ||
+        field->Type().group() != target_type.group()) {
+      continue;
+    }
+
+    // No option values; anything goes.
+    if (field->option_values.empty())
+      return std::set<base::string16>();
+
+    for (size_t i = 0; i < field->option_values.size(); ++i) {
+      values.insert(base::i18n::ToUpper(field->option_values[i]));
+    }
+
+    for (size_t i = 0; i < field->option_contents.size(); ++i) {
+      values.insert(base::i18n::ToUpper(field->option_contents[i]));
+    }
+  }
+
+  return values;
+}

[Ilya Sherman, 2014/03/05 06:09:37]

Since you prefer not to add tests to form_structure_unittest.cc, please move
this code out of the FormStructure class into the anonymous namespace of the
single class implementation that needs it.

[Evan Stade, 2014/03/05 22:38:31]

Don't think I can do that because iOS and Android will likely want this code.
Added a unit test.

+
 void FormStructure::IdentifySections(bool has_author_specified_sections) {
   if (fields_.empty())
     return;
 
   if (!has_author_specified_sections) {
     // Name sections after the first field in the section.
     base::string16 current_section = fields_.front()->unique_name();
 
     // Keep track of the types we've seen in this section.
     std::set<ServerFieldType> seen_types;
@@ skipping 42 matching lines @@
        field != fields_.end(); ++field) {
     FieldTypeGroup field_type_group = (*field)->Type().group();
     if (field_type_group == CREDIT_CARD)
       (*field)->set_section((*field)->section() + "-cc");
     else
       (*field)->set_section((*field)->section() + "-default");
   }
 }
 
 }  // namespace autofill