Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 17826003: Expose WorkerGlobalScope interface in worker environment (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, haraken, Nate Chapin, lgombos
Visibility:
Public.

Description

Expose WorkerGlobalScope interface in worker environment Expose WorkerGlobalScope interface in worker environment as per the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workerglobalscope-common-interface Also expose the SharedWorkerGlobalScope interface when the JavaScript global environment is a shared worker environment, and the DedicatedWorkerGlobalScope interface when the JavaScript global environment is a dedicated worker environment: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworkerglobalscope http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dedicatedworkerglobalscope Split webexposed/global-constructors-listing-worker.html test case into 2 tests (for shared and dedicated workers) to validate the change. The semantics of the [GlobalContext] IDL extended attribute has changed to support this use case. The value for the extended attribute is now the name of the interface to which the Constructor attribute should be added (Window, WorkerGlobalScope, SharedWorkerGlobalScope...). It is possible to specify several interface names by using '&' as separator. For e.g. [GlobalContext=Window&WorkerGlobalScope]. BUG=253473 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153070

Patch Set 1 #

Patch Set 2 : Fix bindings tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -131 lines) Patch
A + LayoutTests/webexposed/global-constructors-listing-dedicated-worker.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 3 chunks +3 lines, -1 line 0 comments Download
A + LayoutTests/webexposed/global-constructors-listing-shared-worker.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 3 chunks +3 lines, -1 line 0 comments Download
D LayoutTests/webexposed/global-constructors-listing-worker.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/webexposed/global-constructors-listing-worker-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
M LayoutTests/webexposed/resources/global-context-constructors-listing.js View 1 chunk +24 lines, -1 line 0 comments Download
M Source/bindings/derived_sources.gyp View 3 chunks +9 lines, -1 line 0 comments Download
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/preprocess_idls.py View 4 chunks +31 lines, -13 lines 0 comments Download
M Source/core/dom/MessageChannel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/Blob.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderSync.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/URL.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/ArrayBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/DataView.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Float32Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Float64Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Int16Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Int32Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Int8Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Uint16Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Uint32Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Uint8Array.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Uint8ClampedArray.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerLocation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-26 08:00:01 UTC) #1
haraken
LGTM BTW, current Blink IDL files use '|' (instead of '&') to specify multiple values. ...
7 years, 6 months ago (2013-06-26 08:34:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17826003/3001
7 years, 6 months ago (2013-06-26 09:44:24 UTC) #3
do-not-use
On 2013/06/26 08:34:08, haraken wrote: > LGTM > > BTW, current Blink IDL files use ...
7 years, 6 months ago (2013-06-26 09:54:01 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2373
7 years, 6 months ago (2013-06-26 09:54:56 UTC) #5
do-not-use
Committed patchset #2 manually as r153070 (presubmit successful).
7 years, 6 months ago (2013-06-26 14:08:44 UTC) #6
arv (Not doing code reviews)
7 years, 6 months ago (2013-06-26 14:16:57 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698