Issue 1782563002: Takeover MT initiated animations from the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1782563002: Takeover MT initiated animations from the compositor (Closed)

Created:
4 years, 9 months ago by ymalik

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

More Reviews

Description

Takeover MT initiated animations from the compositor This is a followup CL to https://crrev.com/1734063003/. It finishes a MT initiated animation running on the compositor, on the MT. BUG=581875 Review URL: https://codereview.chromium.org/1770443002 Cr-Commit-Position: refs/heads/master@{#379868} (cherry picked from commit d0eaee288867a6e00e4a9c3fa65d28e4de9e922a)

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -39 lines)			Patch
M	third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimator.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp	View	5 chunks	+57 lines, -35 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h	View	4 chunks	+12 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp	View	4 chunks	+27 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp	View	2 chunks	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ymalik

Committed patchset #1 (id:1) to pending queue manually as 9228aa5ba6f83b62727de5aeff355533e1169cfd.

4 years, 9 months ago (2016-03-09 18:51:58 UTC) #1

ymalik

4 years, 9 months ago (2016-03-10 02:24:56 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1778223002/ by ymalik@chromium.org.

The reason for reverting is: Merged incorrectly. Will revert for now and
remerge..

Expand Messages | Collapse Messages