chrome/browser/ui/search/search_tab_helper.h - Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment fixes; more symmetry to logImpression() and logNavigation(). Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | chrome/renderer/searchbox/searchbox.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.h

diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h

index cc250d603d4ac80139b673221f4ada918ceb103f..1c6d42fba7a7b25310633ee9769f9b7e0a84a3cc 100644

--- a/chrome/browser/ui/search/search_tab_helper.h

+++ b/chrome/browser/ui/search/search_tab_helper.h

@@ -170,6 +170,8 @@ class SearchTabHelper : public content::WebContentsObserver,

virtual void OnLogEvent(NTPLoggingEventType event) OVERRIDE;

virtual void OnLogImpression(int position,

const base::string16& provider) OVERRIDE;

+ virtual void OnLogNavigation(int position,

+ const base::string16& provider) OVERRIDE;

virtual void PasteIntoOmnibox(const base::string16& text) OVERRIDE;

virtual void OnChromeIdentityCheck(const base::string16& identity) OVERRIDE;