chrome/browser/resources/local_ntp/most_visited_thumbnail.js - Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment fixes; more symmetry to logImpression() and logNavigation(). Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/local_ntp/local_ntp.js ('k') | chrome/browser/resources/local_ntp/most_visited_title.js » ('j') | chrome/renderer/searchbox/searchbox.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

index 4f8b25ed64407a60f6c2ceeffe7f30b73999e96f..688e177416b8d6f7f6d3ab0ca3722685eeef56ea 100644

--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

@@ -23,7 +23,7 @@ window.addEventListener('DOMContentLoaded', function() {

}

function showDomainElement() {

var link = createMostVisitedLink(

- params, data.url, data.title, undefined, data.ping, data.provider);

+ params, data.url, data.title, undefined, data.provider);

var domain = document.createElement('div');

domain.textContent = data.domain;

link.appendChild(domain);

@@ -33,7 +33,7 @@ window.addEventListener('DOMContentLoaded', function() {

// externally by the page itself.

function showEmptyTile() {

displayLink(createMostVisitedLink(

- params, data.url, data.title, undefined, data.ping, data.provider));

+ params, data.url, data.title, undefined, data.provider));

}

// Creates and adds an image.

function createThumbnail(src) {

@@ -42,8 +42,7 @@ window.addEventListener('DOMContentLoaded', function() {

var shadow = document.createElement('span');

shadow.classList.add('shadow');

var link = createMostVisitedLink(

- params, data.url, data.title, undefined, data.ping,

- data.provider);

+ params, data.url, data.title, undefined, data.provider);

link.appendChild(shadow);

link.appendChild(image);

displayLink(link);