chrome/renderer/searchbox/searchbox.cc - Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding and using logNavigation(); updating tests; removing ping and the log.html page. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('K') | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/searchbox/searchbox.cc

diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc

index 893b3dfd516477207314525dd4f37b3bd60dab57..baf906ba2d3b05d19328deaa0d5e87982239d992 100644

--- a/chrome/renderer/searchbox/searchbox.cc

+++ b/chrome/renderer/searchbox/searchbox.cc

@@ -167,6 +167,12 @@ void SearchBox::LogImpression(int position, const base::string16& provider) {

provider));

}

+void SearchBox::LogNavigation(int position, const base::string16& provider) {

+ render_view()->Send(new ChromeViewHostMsg_LogNavigation(

+ render_view()->GetRoutingID(), render_view()->GetPageId(), position,

+ provider));

void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {

render_view()->Send(new ChromeViewHostMsg_ChromeIdentityCheck(

render_view()->GetRoutingID(), render_view()->GetPageId(), identity));