chrome/browser/ui/search/search_tab_helper.cc - Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding and using logNavigation(); updating tests; removing ping and the log.html page. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/search/search_ipc_router.cc ('K') | « chrome/browser/ui/search/search_tab_helper.h ('k') | chrome/browser/ui/search/search_tab_helper_unittest.cc » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index ebfcf5205438decccbf657cdd878c43a97734a54..8f22cc3b2ec422bba54876b88b8e8eb7559163d2 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -544,6 +544,12 @@ void SearchTabHelper::OnLogImpression(int position,

web_contents())->LogImpression(position, provider);

}

+void SearchTabHelper::OnLogNavigation(int position,

+ const base::string16& provider) {

+ NTPUserDataLogger::GetOrCreateFromWebContents(

+ web_contents())->LogNavigation(position, provider);

void SearchTabHelper::PasteIntoOmnibox(const base::string16& text) {

OmniboxView* omnibox = GetOmniboxView(web_contents());

if (!omnibox)