chrome/browser/ui/search/search_ipc_router.h - Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding and using logNavigation(); updating tests; removing ping and the log.html page. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/most_visited_iframe_source_unittest.cc ('k') | chrome/browser/ui/search/search_ipc_router.cc » ('j') | chrome/browser/ui/search/search_ipc_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_ipc_router.h

diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h

index 69dfb52f485fb8100b9ec786997c1402e8885fc0..72eed4504d6e4dfe9977c2f465f99726dce477b6 100644

--- a/chrome/browser/ui/search/search_ipc_router.h

+++ b/chrome/browser/ui/search/search_ipc_router.h

@@ -66,6 +66,10 @@ class SearchIPCRouter : public content::WebContentsObserver {

virtual void OnLogImpression(int position,

const base::string16& provider) = 0;

+ // Called to log a navigation from a given provider on the New Tab Page.

+ virtual void OnLogNavigation(int position,

+ const base::string16& provider) = 0;

// Called when the page wants to paste the |text| (or the clipboard contents

// if the |text| is empty) into the omnibox.

virtual void PasteIntoOmnibox(const base::string16& text) = 0;

@@ -190,6 +194,9 @@ class SearchIPCRouter : public content::WebContentsObserver {

void OnLogImpression(int page_id,

int position,

const base::string16& provider) const;

+ void OnLogNavigation(int page_id,

+ int position,

+ const base::string16& provider) const;

void OnPasteAndOpenDropDown(int page_id, const base::string16& text) const;

void OnChromeIdentityCheck(int page_id, const base::string16& identity) const;