Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/i18n/rtl.h"
 #include "base/json/string_escape.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/autocomplete_match_type.h"
 #include "chrome/common/instant_types.h"
 #include "chrome/common/ntp_logging_events.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/searchbox/searchbox.h"
+#include "content/public/common/url_constants.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/extension.h"
 #include "grit/renderer_resources.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebScriptSource.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/window_open_disposition.h"
@@ skipping 327 matching lines @@
   static void DeleteMostVisitedItem(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Focuses the omnibox.
   static void Focus(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Gets whether or not the app launcher is enabled.
   static void GetAppLauncherEnabled(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
+  // Gets the desired navigation behavior from a click event.
+  static void GetDispositionFromClick(
+      const v8::FunctionCallbackInfo<v8::Value>& args);
+
   // Gets Most Visited Items.
   static void GetMostVisitedItems(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Gets the raw data for a most visited item including its raw URL.
   // GetRenderViewWithCheckedOrigin() enforces that only code in the origin
   // chrome-search://most-visited can call this function.
   static void GetMostVisitedItemData(
     const v8::FunctionCallbackInfo<v8::Value>& args);
 
@@ skipping 25 matching lines @@
   // Gets whether the browser is capturing key strokes.
   static void IsKeyCaptureEnabled(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Logs information from the iframes/titles on the NTP.
   static void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Logs an impression on one of the Most Visited tile on the NTP.
   static void LogImpression(const v8::FunctionCallbackInfo<v8::Value>& args);
 
+  // Logs a navigation on one of the Most Visited tile on the NTP.
+  static void LogNavigation(const v8::FunctionCallbackInfo<v8::Value>& args);
+
   // Navigates the window to a URL represented by either a URL string or a
   // restricted ID.
   static void NavigateContentWindow(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Pastes provided value or clipboard's content into the omnibox.
   static void Paste(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Indicates whether the page supports voice search.
   static void SetVoiceSearchSupported(
@@ skipping 114 matching lines @@
     v8::Handle<v8::String> name) {
   if (name->Equals(
           v8::String::NewFromUtf8(isolate, "CheckIsUserSignedInToChromeAs")))
     return v8::FunctionTemplate::New(isolate, CheckIsUserSignedInToChromeAs);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "DeleteMostVisitedItem")))
     return v8::FunctionTemplate::New(isolate, DeleteMostVisitedItem);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "Focus")))
     return v8::FunctionTemplate::New(isolate, Focus);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetAppLauncherEnabled")))
     return v8::FunctionTemplate::New(isolate, GetAppLauncherEnabled);
+  if (name->Equals(v8::String::NewFromUtf8(isolate, "GetDispositionFromClick")))
+    return v8::FunctionTemplate::New(isolate, GetDispositionFromClick);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetMostVisitedItems")))
     return v8::FunctionTemplate::New(isolate, GetMostVisitedItems);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetMostVisitedItemData")))
     return v8::FunctionTemplate::New(isolate, GetMostVisitedItemData);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetQuery")))
     return v8::FunctionTemplate::New(isolate, GetQuery);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetRightToLeft")))
     return v8::FunctionTemplate::New(isolate, GetRightToLeft);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetStartMargin")))
     return v8::FunctionTemplate::New(isolate, GetStartMargin);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetSuggestionToPrefetch")))
     return v8::FunctionTemplate::New(isolate, GetSuggestionToPrefetch);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "GetThemeBackgroundInfo")))
     return v8::FunctionTemplate::New(isolate, GetThemeBackgroundInfo);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "IsFocused")))
     return v8::FunctionTemplate::New(isolate, IsFocused);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "IsInputInProgress")))
     return v8::FunctionTemplate::New(isolate, IsInputInProgress);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "IsKeyCaptureEnabled")))
     return v8::FunctionTemplate::New(isolate, IsKeyCaptureEnabled);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "LogEvent")))
     return v8::FunctionTemplate::New(isolate, LogEvent);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "LogImpression")))
     return v8::FunctionTemplate::New(isolate, LogImpression);
+  if (name->Equals(v8::String::NewFromUtf8(isolate, "LogNavigation")))
+    return v8::FunctionTemplate::New(isolate, LogNavigation);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "NavigateContentWindow")))
     return v8::FunctionTemplate::New(isolate, NavigateContentWindow);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "Paste")))
     return v8::FunctionTemplate::New(isolate, Paste);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "SetVoiceSearchSupported")))
     return v8::FunctionTemplate::New(isolate, SetVoiceSearchSupported);
   if (name->Equals(
           v8::String::NewFromUtf8(isolate, "StartCapturingKeyStrokes")))
     return v8::FunctionTemplate::New(isolate, StartCapturingKeyStrokes);
   if (name->Equals(v8::String::NewFromUtf8(isolate, "StopCapturingKeyStrokes")))
@@ skipping 56 matching lines @@
 void SearchBoxExtensionWrapper::GetAppLauncherEnabled(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view) return;
 
   args.GetReturnValue().Set(
       SearchBox::Get(render_view)->app_launcher_enabled());
 }
 
 // static
+void SearchBoxExtensionWrapper::GetDispositionFromClick(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  content::RenderView* render_view = GetRenderView();
+  if (!render_view || args.Length() != 5) return;
+
+  bool middle_button = args[0]->BooleanValue();
+  bool alt_key = args[1]->BooleanValue();
+  bool ctrl_key = args[2]->BooleanValue();
+  bool meta_key = args[3]->BooleanValue();
+  bool shift_key = args[4]->BooleanValue();
+
+  WindowOpenDisposition disposition = ui::DispositionFromClick(middle_button,
+                                                               alt_key,
+                                                               ctrl_key,
+                                                               meta_key,
+                                                               shift_key);
+  v8::Isolate* isolate = args.GetIsolate();
+  args.GetReturnValue().Set(v8::Int32::New(isolate, disposition));
+}
+
+// static
 void SearchBoxExtensionWrapper::GetMostVisitedItems(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view)
     return;
   DVLOG(1) << render_view << " GetMostVisitedItems";
 
   const SearchBox* search_box = SearchBox::Get(render_view);
 
   std::vector<InstantMostVisitedItemIDPair> instant_mv_items;
@@ skipping 294 matching lines @@
   if (args.Length() < 2 || !args[0]->IsNumber() || args[1]->IsUndefined())
     return;
 
   DVLOG(1) << render_view << " LogImpression";
 
   SearchBox::Get(render_view)->LogImpression(args[0]->IntegerValue(),
                                              V8ValueToUTF16(args[1]));
 }
 
 // static
+void SearchBoxExtensionWrapper::LogNavigation(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  content::RenderView* render_view = GetRenderViewWithCheckedOrigin(
+      GURL(chrome::kChromeSearchMostVisitedUrl));
+  if (!render_view) return;
+
+  if (args.Length() < 2 || !args[0]->IsNumber() || args[1]->IsUndefined())
+    return;
+
+  DVLOG(1) << render_view << " LogNavigation";
+
+  SearchBox::Get(render_view)->LogNavigation(args[0]->IntegerValue(),
+                                             V8ValueToUTF16(args[1]));
+}
+
+// static
 void SearchBoxExtensionWrapper::NavigateContentWindow(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view || !args.Length()) return;
 
   GURL destination_url;
   bool is_most_visited_item_url = false;
   // Check if the url is a rid
   if (args[0]->IsNumber()) {
     InstantMostVisitedItem item;
     if (SearchBox::Get(render_view)->GetMostVisitedItemWithID(
             args[0]->IntegerValue(), &item)) {
       destination_url = item.url;
       is_most_visited_item_url = true;
     }
   } else {
     // Resolve the URL
     const base::string16& possibly_relative_url = V8ValueToUTF16(args[0]);
-    GURL current_url = GetCurrentURL(render_view);
+  GURL current_url = GetCurrentURL(render_view);
     destination_url = internal::ResolveURL(current_url, possibly_relative_url);
   }
 
   DVLOG(1) << render_view << " NavigateContentWindow: " << destination_url;
 
   // Navigate the main frame.
-  if (destination_url.is_valid()) {
+  if (destination_url.is_valid() &&
+      !destination_url.SchemeIs(content::kJavaScriptScheme)) {

[beaudoin, 2014/03/04 21:33:15]

Any other scheme we should prevent against? I'd defer to a security expert here.

     WindowOpenDisposition disposition = CURRENT_TAB;
-    if (args[1]->Uint32Value() == 2)
-      disposition = NEW_BACKGROUND_TAB;
+    if (args[1]->IsNumber()) {
+      disposition = (WindowOpenDisposition) args[1]->Uint32Value();
+    }
     SearchBox::Get(render_view)->NavigateToURL(destination_url, disposition,
                                                is_most_visited_item_url);
   }
 }
 
 // static
 void SearchBoxExtensionWrapper::Paste(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view) return;
@@ skipping 63 matching lines @@
   if (!render_view) return;
 
   bool display_instant_results =
       SearchBox::Get(render_view)->display_instant_results();
   DVLOG(1) << render_view << " GetDisplayInstantResults" <<
       display_instant_results;
   args.GetReturnValue().Set(display_instant_results);
 }
 
 }  // namespace extensions_v8