Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 178253007: Parse manifest file with app.service_worker.script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index cd6bb03beaf81567bb21e1914826971c06dc3d41..6ed26e8e8b0418a827e8db5c9f4aa5a9381cb80a 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -152,13 +152,19 @@ TEST_F(ManifestTest, ExtensionTypes) {
&manifest, keys::kApp, new base::DictionaryValue());
AssertType(manifest.get(), Manifest::TYPE_LEGACY_PACKAGED_APP);
- // Platform app.
+ // Platform app with event page.
MutateManifest(
&manifest, keys::kPlatformAppBackground, new base::DictionaryValue());
AssertType(manifest.get(), Manifest::TYPE_PLATFORM_APP);
MutateManifest(
&manifest, keys::kPlatformAppBackground, NULL);
+ // Platform app with service worker.
+ MutateManifest(
+ &manifest, keys::kPlatformAppServiceWorker, new base::DictionaryValue());
+ AssertType(manifest.get(), Manifest::TYPE_PLATFORM_APP);
+ MutateManifest(&manifest, keys::kPlatformAppServiceWorker, NULL);
+
// Hosted app.
MutateManifest(
&manifest, keys::kWebURLs, new base::ListValue());

Powered by Google App Engine
This is Rietveld 408576698