Parse manifest file with app.service_worker.script.

chrome/common/extensions/manifest_tests/extension_manifest_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
@@ skipping 24 matching lines @@
     // explicitly.  It will never get invoked.
     Manifest(const Manifest& m);
 
     ~Manifest();
 
     const std::string& name() const { return name_; };
 
     base::DictionaryValue* GetManifest(char const* test_data_dir,
                                        std::string* error) const;
 
-   private:
+   protected:
     const std::string name_;
     mutable base::DictionaryValue* manifest_;
     mutable scoped_ptr<base::DictionaryValue> manifest_holder_;
   };
 
+  // Helper class creating a Manifest object from a string. For readability
+  // single quotes are replaced with double quotes.
+  // E.g. ManifestFromString("{ 'name': 'a' }") parses JSON { "name": "a" }.
+  class ManifestFromString : public Manifest {

[Jeffrey Yasskin, 2014/02/28 01:54:37]

It'd be nice to make this Just Work for Manifest, but eh.

[scheib, 2014/02/28 04:16:07]

Constructor overloaded would be nice - but I don't see a clean way. I think this
subclass is a bit cleaner & more readable at call sites than a static
constructor helper. :\

+   public:
+    explicit ManifestFromString(
+        const char* manifest_as_string_with_single_quotes);
+    ~ManifestFromString();
+
+   protected:
+    scoped_ptr<base::Value> parsed_manifest_holder_;
+  };
+
   // The subdirectory in which to find test data files.
   virtual char const* test_data_dir();
 
   scoped_ptr<base::DictionaryValue> LoadManifest(
       char const* manifest_name,
       std::string* error);
 
   scoped_refptr<extensions::Extension> LoadExtension(
       const Manifest& manifest,
       std::string* error,
@@ skipping 84 matching lines @@
   // Force the manifest tests to run as though they are on trunk, since several
   // tests rely on manifest features being available that aren't on
   // stable/beta.
   //
   // These objects nest, so if a test wants to explicitly test the behaviour
   // on stable or beta, declare it inside that test.
   extensions::ScopedCurrentChannel current_channel_;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_