LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js - Issue 178253006: Output Element defaultValue should be based on textContent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js

Issue 178253006: Output Element defaultValue should be based on textContent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLOutputElement/htmloutputelement-value-expected.txt ('k') | Source/core/html/HTMLOutputElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js

diff --git a/LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js b/LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js

index 14e5658c7b329107543483c03d1883cf84ceb8f5..df032d7e56265df5aba9f3e536c5ea596ec515d4 100644

--- a/LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js

+++ b/LayoutTests/fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js

@@ -119,3 +119,10 @@ shouldBeEqualToString('output.defaultValue', 'defaultValue');

shouldBeEqualToString('output.value', 'aValue');

shouldBeEqualToString('output.innerText', 'aValue');

shouldBeEqualToString('output.innerHTML', 'aValue');

+debug('- Output defaultValue based on textContent if flag is in mode default')

+var output1 = document.createElement('output');

keishi 2014/03/03 02:00:12 nit: Maybe use the variable "output" to match prev

Habib Virji 2014/03/04 11:11:17 Done.

+output1.textContent = 'A';

+shouldBeTrue('output1.defaultValue == \'A\'');

keishi 2014/03/03 02:00:12 Use shouldBeEqualToString.

keishi 2014/03/03 02:00:12 Maybe we should test output1.value too just in cas

Habib Virji 2014/03/04 11:11:17 Done.

+output1.textContent = 'B'

+shouldBeTrue('output1.defaultValue == \'B\'');

keishi 2014/03/03 02:00:12 Ditto.

Habib Virji 2014/03/04 11:11:17 Done.