Issue 178253002: Revert of Use Display changes for screen orientation changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178253002: Revert of Use Display changes for screen orientation changes. (Closed)

Created:
6 years, 10 months ago by jdduke (slow)

Modified:
6 years, 10 months ago

Reviewers:
bulach, timvolodine, mlamouri (slow - plz ping)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@orientation_tests

Visibility:
Public.

Revert of Use Display changes for screen orientation changes. (https://codereview.chromium.org/163433010/) Reason for revert: This is causing runtime issues on pre-JB MR1 devices, as DisplayManager.DisplayListener was added in API level 17. A compat-layer equivalent will be needed before landing. Original issue's description: > Use Display changes for screen orientation changes. > > This is the only reliable solution: we get an event from DisplayManager > every time a display change. If that change is a rotation change from > the display we care about, we can act on it. Using sensors or > onConfigurationChange is unreliable. > > BUG=342714 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252846 TBR=bulach@chromium.org,timvolodine@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=342714 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252940

Created: 6 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -161 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		7 chunks	+35 lines, -77 lines	0 comments	Download
	M	content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationTest.java	View		5 chunks	+100 lines, -84 lines	0 comments	Download

Total messages: 3 (0 generated)

jdduke (slow)

Created Revert of Use Display changes for screen orientation changes.

6 years, 10 months ago (2014-02-24 17:42:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/178253002/1

6 years, 10 months ago (2014-02-24 17:43:58 UTC) #2

Message was sent while issue was closed.

Change committed as 252940