Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1782513002: [Extensions UI Mac] Don't let the top-level actions container be first responder (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Don't let the top-level actions container be first responder The overflow browser actions container needs to accept first responder in order to allow in-menu keyboard navigation; however, the top-level container doesn't need to do this. Don't allow it to become first responder so that focus travels correctly between the omnibox and either the first action or the wrench menu. BUG=592825 Committed: https://crrev.com/dc68af6738e9b8f5c1d2546f67d2bb145e9f74b5 Cr-Commit-Position: refs/heads/master@{#380197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Avi, mind taking a quick look?
4 years, 9 months ago (2016-03-09 19:35:17 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-09 19:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782513002/1
4 years, 9 months ago (2016-03-09 19:42:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 20:15:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:17:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc68af6738e9b8f5c1d2546f67d2bb145e9f74b5
Cr-Commit-Position: refs/heads/master@{#380197}

Powered by Google App Engine
This is Rietveld 408576698