sdk/lib/_internal/compiler/implementation/constants.dart - Issue 17825002: Remove support for 'argument definitions test' from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/constants.dart

Issue 17825002: Remove support for 'argument definitions test' from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove SentinelConstant. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/closure.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/constants.dart

diff --git a/sdk/lib/_internal/compiler/implementation/constants.dart b/sdk/lib/_internal/compiler/implementation/constants.dart

index 06e04fc9325137cfe2fa58adf64ffd0b577f7cac..6b320417656c3ee290a2df2fd5ff782fb305a253 100644

--- a/sdk/lib/_internal/compiler/implementation/constants.dart

+++ b/sdk/lib/_internal/compiler/implementation/constants.dart

@@ -5,7 +5,6 @@

part of dart2js;

abstract class ConstantVisitor<R> {

- R visitSentinel(SentinelConstant constant);

R visitFunction(FunctionConstant constant);

R visitNull(NullConstant constant);

R visitInt(IntConstant constant);

@@ -53,22 +52,6 @@ abstract class Constant {

accept(ConstantVisitor visitor);

}

-class SentinelConstant extends Constant {

- const SentinelConstant();

- static final SENTINEL = const SentinelConstant();

- List<Constant> getDependencies() => const <Constant>[];

- // Just use a random value.

- int get hashCode => 24297418;

- bool isSentinel() => true;

- accept(ConstantVisitor visitor) => visitor.visitSentinel(this);

- DartType computeType(Compiler compiler) => compiler.types.dynamicType;

class FunctionConstant extends Constant {

Element element;