Issue 1782493002: Do not start the service isolate when generating the core library snapshot as it does not load any …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1782493002: Do not start the service isolate when generating the core library snapshot as it does not load any … (Closed)

Created:
4 years, 9 months ago by siva

Modified:
4 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Do not start the service isolate when generating the core library snapshot as it does not load any files or resolve URIs. This ensures that we do not have a race condition of the main isolate shutting down the service isolate before it gets to start. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/7520ecc48b14ec25cc452a9d67b47e151dee895b

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/bin/gen_snapshot.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 9 months ago (2016-03-10 07:24:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7520ecc48b14ec25cc452a9d67b47e151dee895b (presubmit successful).