Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1782463002: Split resolver_test.dart into smaller files. (Closed)

Created:
4 years, 9 months ago by Bob Nystrom
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14883 lines, -14644 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/analysis_context_factory.dart View 1 chunk +562 lines, -0 lines 2 comments Download
A pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 1 chunk +619 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/element_resolver_test.dart View 1 chunk +1011 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +2983 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/analyzer/test/generated/inheritance_manager_test.dart View 1 chunk +1269 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/non_hint_code_test.dart View 1 chunk +1156 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 38 chunks +765 lines, -14627 lines 0 comments Download
A pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +839 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/simple_resolver_test.dart View 1 chunk +1762 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/static_type_analyzer_test.dart View 1 chunk +1619 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +2280 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_elements_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
resolver_test.dart was a 17kloc monstrosity that brought IntelliJ to its knees whenever I opened it, ...
4 years, 9 months ago (2016-03-09 15:58:15 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1782463002/diff/1/pkg/analyzer/test/generated/analysis_context_factory.dart File pkg/analyzer/test/generated/analysis_context_factory.dart (right): https://codereview.chromium.org/1782463002/diff/1/pkg/analyzer/test/generated/analysis_context_factory.dart#newcode1 pkg/analyzer/test/generated/analysis_context_factory.dart:1: // Copyright (c) 2016, the Dart project authors. ...
4 years, 9 months ago (2016-03-09 16:54:09 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as 8defa5f77c870ce968ae7252705e334e4ba6fcdf (presubmit successful).
4 years, 9 months ago (2016-03-09 18:42:14 UTC) #5
Bob Nystrom
4 years, 9 months ago (2016-03-09 18:42:30 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1782463002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/analysis_context_factory.dart (right):

https://codereview.chromium.org/1782463002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/analysis_context_factory.dart:1: // Copyright (c)
2016, the Dart project authors.  Please see the AUTHORS file
On 2016/03/09 16:54:09, Brian Wilkerson wrote:
> I don't know whether it matters, but in the past we've preserved the copyright
> date on code when it's been moved.

I was looking at this as a new file, since the old resolver_test.dart is still
there too.

Powered by Google App Engine
This is Rietveld 408576698